Nested resources inherit requirements on parent ids

+1 this makes a lot of sense. Since the child resource inherits the parent into their URL surely you'd expect the requirements to come across with it.

This almost works with the new router now:

  # Works
  resources :movies, :id => /\d+/ do
    resources :reviews
  end

  # Works
  resources :movies, :constraints => { :id => /\d+/ } do
    resources :reviews
  end

  # Works
  scope :id => /\d+/ do
    resources :movies do
      resources :reviews
    end
  end

  # Fails
  scope :constraints => { :id => /\d+/ } do
    resources :movies do
      resources :reviews
    end
  end

  # Fails
  constraints :id => /\d+/ do
    resources :movies do
      resources :reviews
    end
  end

This is because :constraints is a separate hash in the scope. The attached patch merges the constraints from the scope into the resource options.

I'm still seeing this bug in Actionpack (3.0.0.rc2) but it has been marked as resolved ?

You are using the new router dsl, right? I'm asking because your example is using the old syntax (and it doesn't work using the old syntax). If you're using the old syntax then nothing will have changed as that's been kept the same deliberately to ease the migration of old apps.

Now I'm not sure if this is the same issue or a slight variation:

resources :foo, :constraints => { :id => /\d+/ } do
resources :bar end

rake routes:

edit_foo_bar GET    /foo/:foo_id/bar/:id/edit(.:format)          {:id=>/\d+/, :foo_id=>/\d+/, ...}
   foo_bar GET    /foo/:foo_id/bar/:id(.:format)               {:id=>/\d+/, :foo_id=>/\d+/, ...}
   foo_bar PUT    /foo/:foo_id/bar/:id(.:format)               {:id=>/\d+/, :foo_id=>/\d+/, ...}
   foo_bar DELETE /foo/:foo_id/bar/:id(.:format)               {:id=>/\d+/, :foo_id=>/\d+/, ...}

here you can see both :foo_id and :id inherit the constraint. It should only be :foo_id

Moments later I spot the typo:

the nested resource should be declared singularly so resource not resources

resources :foo, :constraints => { :id => /\d+/ } do
resource :bar end

is there a use case for

resources :foo do
resources :bar end

or should it throw an error ?