#2749 Can I get a plus one on my plus one? - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2749 ✓resolved

Can I get a plus one on my plus one?

Reported by Aaron Patterson | June 3rd, 2009 @ 06:42 AM | in 2.x

Yo dawg, I heard you liked plus ones with your evals. So I put a plus one in your eval so you can get line numbers in your debugs.

@wycats, you need to get online more often so I don't have to open tickets. :-P

plus_one.diff 967 Bytes

Comments and changes to this ticket

Manfred Stienstra June 3rd, 2009 @ 09:27 AM
- Tag set to “plusone”
+1, I don't care how you fix it. I need this ASAP.
Eloy Duran June 3rd, 2009 @ 09:29 AM
- Tag cleared.
+1 for the fix, -1 for the test coverage. But +1 again for the fix which is actually much more important, so I don't care how but let's get this applied!

Maybe we should start a long talk on the ML about the various ways we could implement this? For instance, I personally would prefer "LINE+1".
Eloy Duran June 3rd, 2009 @ 09:32 AM
- Tag set to “plusone, plusonemore”
+0.1
Eloy Duran June 3rd, 2009 @ 09:57 AM
Ohh, and -1 for LH's preview functionality, which made me mess up the formatting, again.
You flagged this item as spam.
ymendel June 3rd, 2009 @ 10:34 PM
+1

And it'll be another +1 for every extra increment to __LINE__
You flagged this item as spam.
Rick Bradley June 3rd, 2009 @ 10:46 PM
+1, fool.
You flagged this item as spam.
Gregory Brown June 3rd, 2009 @ 11:02 PM
1. tenderlove FTW
You flagged this item as spam.
Ben Bleything June 3rd, 2009 @ 11:08 PM
yo dawg I heard you like plus ones so I put a plus one in your ticket so you can plus one while you plus one
You flagged this item as spam.
Evan Phoenix June 4th, 2009 @ 12:28 AM
+3 for the fix, -2 for it not trigging a test failure, for a grand total of...
```
    _    /_ |
  _| |_   | |
 |_   _|  | |
   |_|    | |
          |_|
```
You flagged this item as spam.
Evan Phoenix June 4th, 2009 @ 12:28 AM
My figlet failed. Thats a +1. :(
Eloy Duran June 4th, 2009 @ 11:43 AM
- State changed from “new” to “verified”
Carl Lerche July 2nd, 2009 @ 07:40 PM
+1

I'm a sucker for following trends.
Repository July 2nd, 2009 @ 07:41 PM
- State changed from “verified” to “resolved”
(from [49bdbebca69cabea6e4cea6e09cb61dc990bb1f7]) wycats forgot a +1, so I added it [#2749 state:resolved]

Signed-off-by: Yehuda Katz + Carl Lerche ykatz+clerche@engineyard.com
http://github.com/rails/rails/commit/49bdbebca69cabea6e4cea6e09cb61...