This project is archived and is in readonly mode.
Can I get a plus one on my plus one?
Yo dawg, I heard you liked plus ones with your evals. So I put a plus one in your eval so you can get line numbers in your debugs.
@wycats, you need to get online more often so I don't have to open tickets. :-P
-
plus_one.diff
967 Bytes
-
-
Eloy Duran- Tag cleared.
+1 for the fix, -1 for the test coverage. But +1 again for the fix which is actually much more important, so I don't care how but let's get this applied!
Maybe we should start a long talk on the ML about the various ways we could implement this? For instance, I personally would prefer "LINE+1".
-
-
Eloy Duran
Ohh, and -1 for LH's preview functionality, which made me mess up the formatting, again.
-
ymendel+1
And it'll be another +1 for every extra increment to __LINE__
-
Rick Bradley
+1, fool.
-
Gregory Brown- tenderlove FTW
-
Ben Bleythingyo dawg I heard you like plus ones so I put a plus one in your ticket so you can plus one while you plus one
-
Evan Phoenix
+3 for the fix, -2 for it not trigging a test failure, for a grand total of...
_ /_ | _| |_ | | |_ _| | | |_| | | |_| -
Evan Phoenix
My figlet failed. Thats a +1. :(
-
Eloy Duran
- State changed from new to verified
-
Carl Lerche
+1
I'm a sucker for following trends.
-
Repository
- State changed from verified to resolved
(from [49bdbebca69cabea6e4cea6e09cb61dc990bb1f7]) wycats forgot a +1, so I added it [#2749 Can I get a plus one on my plus one? state:resolved]
Signed-off-by: Yehuda Katz + Carl Lerche ykatz+clerche@engineyard.com
http://github.com/rails/rails/commit/49bdbebca69cabea6e4cea6e09cb61...