This project is archived and is in readonly mode.
avoid calling #valid? on destroyed associated records
An associated record may be invalid in memory even though it has been destroyed in the database. This should not prevent the parent object from being valid.
-
cainlevyIt'd probably help if I hadn't commented out the code that, you know, does stuff.
Eloy also suggested aliasing #frozen? to #destroyed? for better semantics.
-
Eloy Duran- State changed from new to verified
- Milestone changed from 2.x to 2.3.4
I have verified and applied this patch on my branch of 2-3-stable, which Micheal will look at and merge in before 2.3.4.
http://github.com/alloy/rails/commit/c6cd7638dc72e241d8251538a9c6ea...
Thanks!
-
cainlevy
Looks like it didn't make it in. Bump to next milestone?
-
Dmitry PolushkinYeah, still waiting...
-
Eloy Duran
Yes very unfortunate, sorry. I suspect the sudden urge to get a release out because of the security fixes caused this. I'll communicate with Michael to make sure we get it in 2.3.5.
-
-
Repository
- State changed from verified to resolved
(from [7c1e4ef64bd26927708da641584a6a13d9b1391c]) Don't cascade autosave validation to destroyed children. [#2761 avoid calling #valid? on destroyed associated records state:resolved] Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/7c1e4ef64bd26927708da641584a6a... -
Repository
(from [a44a1257d879311d88c2d10c366ab0d6561f903a]) Don't cascade autosave validation to destroyed children. [#2761 avoid calling #valid? on destroyed associated records state:resolved] Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/a44a1257d879311d88c2d10c366ab0...