This project is archived and is in readonly mode.
Rollup: Fix issues with 2.3.2 gem loader
Reported by Matt Jones | June 6th, 2009 @ 11:12 PM | in 2.3.3
Fix several issues with the 2.3.2 gem loader.
Incorporates the following:
-
migrates back small change to gems:build:force from bfc1609a501fc3ed442685819de5bcdb5fbada1c to finish closing #2266.
-
unrolls to_proc calls in gems.rake, to match the change in master.
-
fixes #2722 by passing the options hash to dependencies during build. (includes a test)
-
fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.
-
fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.
-
fixes #2678 by passing the options hash to dependencies during unpack.
Patches attached for both 2-3-stable and master.
Comments and changes to this ticket
-
-
-
-
Michael Koziarski June 9th, 2009 @ 05:02 AM
- Assigned user set to “Michael Koziarski”
- State changed from “new” to “open”
-
Graeme Mathieson June 9th, 2009 @ 05:27 AM
Looks good to me -- solves all my issues and more. +1. Thanks!
-
Michael Koziarski June 9th, 2009 @ 08:58 AM
- State changed from “open” to “resolved”
Pushed to 2-3-stable and master
-
-
Matt Jones June 9th, 2009 @ 04:07 PM
- State changed from “resolved” to “open”
@eagle.anton - good catch!
Eagle's patch should be applied - otherwise spec_filename (in from_directory_name) gets an extra copy of unpacked_path attached to it.
-
Matt Jones June 9th, 2009 @ 05:30 PM
Correctly formatted patches against 2-3-stable and master (new LH multi-file upload FTW).
Also includes a test. -
Michael Koziarski June 9th, 2009 @ 10:59 PM
- State changed from “open” to “resolved”
Pushed to 2-3-stable and master,
Matt. fyi the master diff had a rogue patch file included so you might get merge conflicts when you pull
-
Ryan Heneise June 24th, 2009 @ 03:54 AM
To avoid merge conflicts when checking out the 2-3-stable branch, do the following:
git clone -n git://github.com/rails/rails.git cd rails git co -t -b 2-3-stable git pull
Adding "-n" to git clone prevents it from automatically checking out the HEAD when you do the clone. Then you can track the stable branch and pull it without conflicts.
-
Ryan Heneise June 24th, 2009 @ 03:55 AM
Bah... code blocks:
git clone -n git://github.com/rails/rails.git cd rails git co -t -b 2-3-stable git pull
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
David Dollar
eagleas
Matt Jones
Michael Koziarski
Attachments
Referenced by
-
2722
Force gem dependencies to rebuild if I run rake gems:build:force
@Graeme - can you take a look at the patch on #2773? It
i...
-
2721
Vendor gem failing rake gems:build
The real issue here was the the environment wasn't loaded...
-
2679
rake gems:refresh_specs should refresh all frozen gems
The unrolled variant of this is included in #2773.
-
2678
Recursively unpack gem dependencies *and their dependencies*
A fix for this is included in #2773.
-
2722
Force gem dependencies to rebuild if I run rake gems:build:force
I'm happy for this ticket to be closed alongside #2773 be...
-
2721
Vendor gem failing rake gems:build
I'm happy for this ticket to be closed alongside #2773 be...
-
2679
rake gems:refresh_specs should refresh all frozen gems
I'm happy for this ticket to be closed alongside #2773 be...
-
2678
Recursively unpack gem dependencies *and their dependencies*
I'm happy for this ticket to be closed alongside #2773 be...