Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

rake gems:refresh_specs should refresh all frozen gems

#2679

Attached is a patch so that:

rake gems:refresh_specs

will refresh all frozen specs, not just current_gems. That way, the specs of unpacked dependencies will be refreshed too.

Reported by Graeme Mathieson · May 20th, 2009 @ 07:04 AM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. David Dollar
    David Dollar

    Looks good. If you could add a second patch rebased against master (the Symbol#to_proc shortcut has been unrolled there) it would probably help out the committer.

    May 27th, 2009 @ 05:39 PM

  2. Matt Jones
    Matt Jones

    The unrolled variant of this is included in #2773.

    June 6th, 2009 @ 11:22 PM

  3. Graeme Mathieson
    Graeme Mathieson

    Awesome, thanks Matt!

    I'm happy for this ticket to be closed alongside #2773 being resolved.

    June 9th, 2009 @ 05:32 AM

  4. Repository
    Repository
    • State changed from new to committed

    (from [2c3d2906b255b1cb3aeb5d3abb9fe2dcb2872c28]) Fix several issues with the 2.3.2 gem loader.

    Incorporates the following:

    • migrates back small change to gems:build:force from bfc1609a501fc3ed442685819de5bcdb5fbada1c to finish closing #2266.

    • unrolls to_proc calls in gems.rake, to match the change in master.

    • fixes #2722 by passing the options hash to dependencies during build. (includes a test)

    • fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.

    • fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.

    • fixes #2678 by passing the options hash to dependencies during unpack.

    Signed-off-by: Michael Koziarski michael@koziarski.com
    http://github.com/rails/rails/commit/2c3d2906b255b1cb3aeb5d3abb9fe2...

    June 9th, 2009 @ 08:58 AM

  5. Repository
    Repository

    (from [41a94048e55e082f373e19d9fcee311860aaba9e]) Fix several issues with the 2.3.2 gem loader.

    Incorporates the following:

    • migrates back small change to gems:build:force from bfc1609a501fc3ed442685819de5bcdb5fbada1c to finish closing #2266.

    • unrolls to_proc calls in gems.rake, to match the change in master.

    • fixes #2722 by passing the options hash to dependencies during build. (includes a test)

    • fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.

    • fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.

    • fixes #2678 by passing the options hash to dependencies during unpack.

    Signed-off-by: Michael Koziarski michael@koziarski.com
    http://github.com/rails/rails/commit/41a94048e55e082f373e19d9fcee31...

    June 9th, 2009 @ 08:58 AM