Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Rollup: Fix issues with 2.3.2 gem loader

#2773

Fix several issues with the 2.3.2 gem loader.

Incorporates the following:

  • migrates back small change to gems:build:force from bfc1609a501fc3ed442685819de5bcdb5fbada1c to finish closing #2266.

  • unrolls to_proc calls in gems.rake, to match the change in master.

  • fixes #2722 by passing the options hash to dependencies during build. (includes a test)

  • fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.

  • fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.

  • fixes #2678 by passing the options hash to dependencies during unpack.

Patches attached for both 2-3-stable and master.

Reported by Matt Jones · June 6th, 2009 @ 11:12 PM

State: resolved
Milestone: 2.3.3
Assigned to: Michael Koziarski Michael Koziarski
Importance: High

Activity

  1. Matt Jones
    Matt Jones

    Patch against 2-3-stable.

    June 6th, 2009 @ 11:12 PM

  2. Matt Jones
    Matt Jones

    Patch against master.

    June 6th, 2009 @ 11:12 PM

  3. David Dollar
    David Dollar

    +1 Looks great.

    June 6th, 2009 @ 11:27 PM

  4. Michael Koziarski
    Michael Koziarski
    • Assigned user set to Michael Koziarski
    • State changed from new to open

    June 9th, 2009 @ 05:02 AM

  5. Graeme Mathieson
    Graeme Mathieson

    Looks good to me -- solves all my issues and more. +1. Thanks!

    June 9th, 2009 @ 05:27 AM

  6. Michael Koziarski
    Michael Koziarski
    • State changed from open to resolved

    Pushed to 2-3-stable and master

    June 9th, 2009 @ 08:58 AM

  7. eagle.anton (at gmail)
    eagle.anton (at gmail)

    Patches has wrong paths for specification files.

    June 9th, 2009 @ 12:09 PM

  8. Matt Jones
    Matt Jones
    • State changed from resolved to open

    @eagle.anton - good catch!

    Eagle's patch should be applied - otherwise spec_filename (in from_directory_name) gets an extra copy of unpacked_path attached to it.

    June 9th, 2009 @ 04:07 PM

  9. Matt Jones
    Matt Jones

    Correctly formatted patches against 2-3-stable and master (new LH multi-file upload FTW).
    Also includes a test.

    June 9th, 2009 @ 05:30 PM

  10. Michael Koziarski
    Michael Koziarski
    • State changed from open to resolved

    Pushed to 2-3-stable and master,

    Matt. fyi the master diff had a rogue patch file included so you might get merge conflicts when you pull

    June 9th, 2009 @ 10:59 PM

  11. Ryan Heneise
    Ryan Heneise

    To avoid merge conflicts when checking out the 2-3-stable branch, do the following:

    git clone -n git://github.com/rails/rails.git cd rails git co -t -b 2-3-stable git pull

    Adding "-n" to git clone prevents it from automatically checking out the HEAD when you do the clone. Then you can track the stable branch and pull it without conflicts.

    June 24th, 2009 @ 03:54 AM

  12. Ryan Heneise
    Ryan Heneise

    Bah... code blocks:

    git clone -n git://github.com/rails/rails.git
cd rails
git co -t -b 2-3-stable
git pull

    June 24th, 2009 @ 03:55 AM