fixed counter_sql from finder_sql to work with subselects

Hey,

The patch doesn't apply cleanly. Also, could you please fix your email in the patch ?

git config --global user.name "Your Name"
git config --global user.email your_email@your-domain.com

are there adapters which dont support subqueries?

I changed the sql, now works with sqlite3 and should not be adapter specific.

hope this is the final version^^

The test still fails for me on sqlite3.

  1) Error:
test_counting_from_finder_sql_with_subselect(HasManyAssociationsTest):
ActiveRecord::StatementInvalid: SQLite3::SQLException: near ")": syntax error: SELECT COUNT(*) FROM companies LIMIT 1) IS NOT NULL;
    ./cases/../../lib/active_record/connection_adapters/abstract_adapter.rb:214:in `log'
    ./cases/../../lib/active_record/connection_adapters/sqlite_adapter.rb:168:in `execute_without_query_record'
    ./cases/../../lib/active_record/connection_adapters/sqlite_adapter.rb:413:in `catch_schema_changes'
    ./cases/../../lib/active_record/connection_adapters/sqlite_adapter.rb:168:in `execute_without_query_record'
    ./cases/helper.rb:41:in `execute'
    ./cases/../../lib/active_record/connection_adapters/sqlite_adapter.rb:316:in `select'
    ./cases/../../lib/active_record/connection_adapters/abstract/database_statements.rb:7:in `select_all_without_query_cache'
    ./cases/../../lib/active_record/connection_adapters/abstract/query_cache.rb:62:in `select_all'
    ./cases/../../lib/active_record/connection_adapters/abstract/database_statements.rb:13:in `select_one'
    ./cases/../../lib/active_record/connection_adapters/abstract/database_statements.rb:19:in `select_value'
    ./cases/../../lib/active_record/base.rb:956:in `count_by_sql'
    ./cases/../../lib/active_record/associations/association_collection.rb:169:in `count'
    cases/associations/has_many_associations_test.rb:36:in `test_counting_from_finder_sql_with_subselect'
    ./cases/../../lib/../../activemodel/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `__send__'
    ./cases/../../lib/../../activemodel/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:62:in `run'

strange, i only get this error without the fix.

i rebased and removed a conflict.

also 2 other developers tried my patch and they got no error.
i have no idea why its failing on your machine.

tested on:
windows xp, ruby 1.8.6, sqlite3-ruby 1.2.5 with sqlite 3.5.6
ubuntu, ruby 1.9.1, sqlite3-ruby 1.2.4 with sqlite 3.6.10

this is still an issue in edge..

SELECT * FROM articles WHERE id IN (SELECT article_id FROM comments WHERE text LIKE '%test%');