This project is archived and is in readonly mode.
Encode JSON in UTF-8 instead of BINARY
Since default internal and external encodings are set to UTF-8 now (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY here.
And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to the JSON RFC.
Attached a patch.
-
json_binary_encoding_fix.diff
1.18 KB
-
Repository- State changed from new to resolved
(from [49824e8ad64be17d6b8a0356bc30342aecc72216]) JSON.escape returns UTF-8 strings
[#2849 Encode JSON in UTF-8 instead of BINARY state:resolved] http://github.com/rails/rails/commit/49824e8ad64be17d6b8a0356bc3034...
-
Repository
(from [5217c16b094a07919348b52aa164ca2fd26b5d5e]) JSON.escape returns UTF-8 strings
[#2849 Encode JSON in UTF-8 instead of BINARY state:resolved] http://github.com/rails/rails/commit/5217c16b094a07919348b52aa164ca...