This project is archived and is in readonly mode.
to_xml generated <foo type="binary"> tags not accepted by from_xml
Converting binary data to XML creates ... tags. Sending the same tag back to rails fails to decode the base64 because the from_xml doesn't acknowledge the type="binary" attribute. It expects a type="binaryBase64" attribute, instead.
The attached patch adds support for a type="binary" with an optional encoding="base64". If the encoding attribute is absent, the data is considered unencoded.
-
base64.diff
1.85 KB
-
John FranklinStupid lighthouse. Let's try this again:
The tags noted in the bug should be:
... -
John Franklin
Grr... (If only there were a preview button next to the "update ticket" button)
<mydata type="binary" encoding="base64">...</mydata> -
John Franklin
- Tag changed from binary, from_xml, xml to binary, from_xml, patch, xml
-
CancelProfileIsBroken
- Tag changed from binary, from_xml, patch, xml to binary, bugmash, from_xml, patch, xml
-
Josh Nichols- Tag changed from binary, bugmash, from_xml, patch, xml to binary, bugmash, from_xml, patch, verified, xml
+1, because without this patch, the attribute gets serialized as 'true'.
Verified the patch applies and works as intended.
-
Jörg B.+1 ... tested it aswell
-
Rizwan Reza- State changed from new to verified
- Tag changed from binary, bugmash, from_xml, patch, verified, xml to binary, from_xml, patch, verified, xml
- Milestone cleared.
-
Rizwan Reza
This applies cleanly to master.
-
Rizwan Reza
- Assigned user set to José Valim
-
Repository
- State changed from verified to resolved
(from [c7cc9583689d63d342983d739ccf5c4e94233a48]) Add support for a type=binary with an optional encoding=base64. If the encoding attribute is absent, the data is considered unencoded. [#2966 to_xml generated <foo type="binary"> tags not accepted by from_xml state:resolved] http://github.com/rails/rails/commit/c7cc9583689d63d342983d739ccf5c...
-
