Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Added more support to ActionView::Base.erb_variable

#298

If we change ActionView::Base.erb_variable, cache_fragment doesn't work and some javascript functions also, because they are checking for the existence of '_erbout' instead of the variable set in erb_variable.

It's just a small patch, that fix javascript functions and send erb_variable to Erb.new().

I also added the line below in fragment cache tests setup to assure that they are working with any variable set.

ActionView::Base.erb_variable = '_buf'

Reported by José Valim · June 2nd, 2008 @ 12:26 PM

State: invalid
Milestone: none
Assigned to: Pratik Pratik
Importance: none

Activity

  1. Pratik
    Pratik
    • State changed from new to incomplete

    Getting 25 actionpack failures/errors.

    June 2nd, 2008 @ 01:24 PM

  2. José Valim
    José Valim

    Oh, I forgot to add a teardown at the end of tests.

    Attached another patch. Applying both should work! =)

    June 2nd, 2008 @ 01:47 PM

  3. Pratik
    Pratik
    • State changed from incomplete to open
    • Assigned user set to Pratik

    June 2nd, 2008 @ 01:54 PM

  4. Pratik
    Pratik
    • State changed from open to invalid
    • Milestone cleared.

    Not relevant anymore as we got rid of _erbout variable.

    Thanks.

    June 17th, 2008 @ 06:54 PM