Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

BlankSlate is not Ruby 1.9 compatible

#3001

Ruby 1.9, Object#methods and Object#instance_methods returns a list of symbols. This code in BlankSlate expects the pre-1.9 behavior.


{mkd-extraction-9185223c51f360f4b08f075ac44c6cdd}

Without this change, no methods are ever actually hidden in Ruby 1.9, because the method names (as strings) are never found.

The attached patch is a small change to (Builder) BlankSlate.

Reported by David Reese · August 6th, 2009 @ 07:06 PM

State: wontfix
Milestone: 2.3.6
Assigned to: Jeremy Kemper Jeremy Kemper
Importance: none

Activity

  1. David Reese
    David Reese

    Sorry; this diff includes another fix, for cases when hide(name) is passed a string instead of a :symbol.

    August 6th, 2009 @ 09:44 PM

  2. David Reese
    David Reese

    Slowly working through all the errors, apparently.

    Now: preventing BlankSlate from hiding #object_id; otherwise Ruby1.9 throws this funny little warning:

    warning: undefining object_id' may cause serious problem

    August 6th, 2009 @ 10:10 PM

  3. Jeremy Kemper
    Jeremy Kemper
    • Assigned user set to Jeremy Kemper
    • State changed from new to open
    • Milestone set to 2.3.4

    August 7th, 2009 @ 06:45 AM

  4. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.4 to 2.3.6

    [milestone:id#50064 bulk edit command]

    September 11th, 2009 @ 11:04 PM

  5. Jeremy Kemper
    Jeremy Kemper
    • State changed from open to wontfix

    This is in the bundled builder lib, so should be contributed directly upstream. In Rails 3, builder is unbundled entirely.

    April 24th, 2010 @ 08:19 PM