Rails Ruby on Rails → 2.3.6

Comments and changes to this ticket

• You flagged this item as spam.
  

  Jamie Rumbelow August 26th, 2009 @ 10:47 AM

  This behavior seems correct - calling the user.memberships touches the group (updating one of it's attributes) and then the autosave falls back down through the associations to find that the group has been changed, thus updating it's attribute.

  Nothing wrong here.

• You flagged this item as spam.
  

  Florent2 August 26th, 2009 @ 05:14 PM

  Jamie I am not sure I understand what you wrote.

  From what I see in my console sequence, calling "user.memberships" does not touch the group, it just loads the membership associated to the user. When I save the user, the membership is not updated in the DB as it has not changed itself. As the membership record does not change in the database, I don't understand why the group is updated in the database.

  Sounds like a bug for me.

• You flagged this item as spam.
  

  Florent2 August 26th, 2009 @ 06:18 PM

  I've looked in ActiveRecord code and now I think I understand what you mean Jamie.

  :autosave option calls the save method of the loaded association records. In my case the association (membership) has not changed so when its save method is called, the DB record is not changed.

  But calling this save method is enough for the touch mechanism to occur, that's why the group is updated in the database. This is because touch is implemented as a after_save callback.

  I could "fix" my problem by changing the autosave code so that it calls the association save method only if the association itself has changed. In activerecord-2.3.3/lib/active_record, method save_collection_association I changed the last condition
  

  elsif autosave
    record.save(false)
  end
  

  into
  

  elsif autosave && record.changed?
    record.save(false)
  end
  
  
  
  
  
  
  
  I am not familiar with Rails internals and structure, so before going further and submitting a patch with tests, I would like to know if it the right way to fix this issue. Any indication would appreciated :)
  

• You flagged this item as spam.
  

  Kane August 28th, 2009 @ 04:38 PM

  only saving the record when it changed seems fine with me and should be done even if it would work with your touch example.
  if somebody needs to save all associated records every time for what ever he might need touch for has_many.

  i thought of a case where people validate the association record with stuff from the parent, say association.name must be present if parent is in state open or something like this. but that wouldnt be affected cause validations would still be done.

  so +1 from me for adding "&& record.changed?"

• 

  Eloy Duran December 30th, 2009 @ 07:42 PM

  • Assigned user set to “Eloy Duran”
  • Milestone set to “2.3.6”
• 

  Eloy Duran January 8th, 2010 @ 11:21 AM

  • State changed from “new” to “resolved”

  This has been fixed in our repo, which will be merged shortly:

  2-3-stable: http://github.com/Fingertips/rails/commit/aa29cdf57f5ed57db8e4e3ec1...
  master: http://github.com/Fingertips/rails/commit/e75d92a749f9464b95868e353...

  Thanks

• You flagged this item as spam.
  

  Florent2 January 12th, 2010 @ 01:52 PM

  Thanks!