This project is archived and is in readonly mode.

#3159 ✓invalid
Kostas K.

assert_valid is deprecated in unit tests but not in functional tests

Reported by Kostas K. | September 7th, 2009 @ 03:39 PM

http://github.com/rails/rails/commit/d4754677a34d34d4a0955a04f2cc65... says that assert_valid is deprecated but it is still usable in functional tests (as of 2.3.3) which makes no sense.
Is it going to be removed or kept?

Comments and changes to this ticket

  • David Trasbo

    David Trasbo April 15th, 2010 @ 11:47 AM

    • Assigned user set to “Ryan Bigg”

    To "deprecate" means to schedule a piece of functionality for removal in a future version and issue a warning when its used to make people aware that they will not be able to use it sooner or later.

    assert_valid does not exist in ActiveSupport::TestCase but it's scheduled to be removed from ActionController::TestCase. This ticket can be marked as invalid.

  • Ryan Bigg

    Ryan Bigg April 15th, 2010 @ 12:46 PM

    • State changed from “new” to “invalid”

    David's right, they'll still be available but should be raising deprecation warnings.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages