This project is archived and is in readonly mode.
[PATCH] For Rails 2.3 stable. Add layout override option to ActionMailer
There's current no way override a layout for a given action mailer action. With actioncontroller, you can always explicitly set :layout in a render call, but many times you are using the default :render with actionmailer. Following the actionmailer pattern of using accessors, I've added a new accessor for setting the layout of an action. I've attached the patch for the 2-3-stable branch. Let me know if you'd like a patch for master, but right now all of the unit test for layouts are broken, so I'm sure it's in flux right now.
ExampleMailer < ActionMailer::Base
layout "default"
def example(recipient)
recipients recipient
subject "You have a mail"
from "tester@example.com"
layout "other"
end end
-
Scott Windsor- Tag changed from action_mailer to 2-3-stable, 2.3, action_mailer
-
Scott Windsor
- Tag changed from 2-3-stable, 2.3, action_mailer to 2-3-stable, 2.3, action_mailer, patch
-
CancelProfileIsBroken- Tag changed from 2-3-stable, 2.3, action_mailer, patch to 2-3-stable, 2.3, action_mailer, bugmash, patch
-
Blue Box Jesse+1
Logic for the feature makes sense and allows for easy clean up of Action Mailer templates.
Patch applies successfully to 2.3.0.
Only concern is the test no longer checks that the old formatting works. Would it be worth while to have two tests?
-
Scott Windsor
Jesse, do you know why the old test are broken? If so, I don't mind fixing them.
-
Anuj Dutta+1 - for the idea.
The tests aren't broken on 2-3-stable.
-
sr.iniv.t
+1 verified.
The idea is nice addition. The patch applies cleanly on 2-3-stable and tests pass.
-
Elad Meidar
+1 verified on Master and 2-3-stable, -1 on patch.... i'd rather to have a new test as Jesse suggested, rather than replacing the existing one.
-
Scott Windsor
Makes sense to me. Here's the new patch with new unit tests. Thanks for the feedback!
-
Anuj Dutta
Got errors on applying the patch to 2-3-stable.
-
Scott Windsor
andhap, could you add the errors you got?
-
Anuj Dutta
error: patch failed: actionmailer/lib/action_mailer/base.rb:354 error: actionmailer/lib/action_mailer/base.rb: patch does not apply error: patch failed: actionmailer/test/mail_layout_test.rb:14 error: actionmailer/test/mail_layout_test.rb: patch does not apply
On 2-3-stable
-
Scott Windsor
Look like there have been commits since my last patch. Here's the lastest one - let me know if it works for you now.
-
Anuj Dutta
Nope same error message. May be someone else should verify it as well because I have applied several patches and my fork is ahead of yours probably.
-
Scott Windsor
Try applying on a clean 2-3-stable branch and see if it applies cleanly.
-
Scott Windsor
any update? this is still working good for me. Who should I contact to review this?
-
Anuj Dutta
I will apply it to the current 2-3-stable branch today and let you know the outcome.
-
Anuj Dutta
I applied it and it does not give me any errors now. Hope it helps.
-
Rizwan Reza- Tag changed from 2-3-stable, 2.3, action_mailer, bugmash, patch to 2-3-stable, 2.3, action_mailer, patch
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2-3-stable, 2.3, action_mailer, patch to 2-3-stable, 23, action_mailer, patch
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
swindsorThis isn't a bugfix, it's a feature request. I'm trying to help the rails team out by providing new functionality. It's for rails 2-3-stable, not rails 3.