This project is archived and is in readonly mode.
PostgreSQL escape methods aren't thread-safe (in Ruby 1.8)
PostgreSQL adapter has code like that
def query_string(s)
self.class.instance_eval do
define_method(:query_string) do |s|
@connection.query_string(s)
end
end
query_string(s)
end
In ruby 1.8 it's not thread-safe because block's argument is bound to method's argument. So when you call this method in several threads it could return value you aren't expecting.
- http://pastie.org/623434 triggers the bug instantaneously (attached as wierd_test.rb)
- http://pastie.org/623444 triggers the bug with ActiveRecord (attached as test.rb).
Patch renames methods' arguments original_value, so blocks' arguments are no longer bound to them.
-
test.rb
988 Bytes
-
wierd_test.rb
467 Bytes
-
0001-PostgreSQL-adapter-escape_bytea-quote_string-and-une.patch
2.57 KB
-
CancelProfileIsBroken- Tag changed from ruby 1.8.7, 1.8.6, activerecord, adapters, patch, postgres, postgresql to ruby 1.8.7, 1.8.6, activerecord, adapters, bugmash, patch, postgres, postgresql
- Assigned user cleared.
-
Rizwan Reza- Milestone cleared.
- Tag changed from ruby 1.8.7, 1.8.6, activerecord, adapters, bugmash, patch, postgres, postgresql to ruby 1.8.7, 1.8.6, activerecord, adapters, patch, postgres, postgresql
- State changed from new to verified
- Assigned user set to Pratik
Applies cleanly to master and 2-3-stable.
-
Rizwan Reza
- Assigned user changed from Pratik to Yehuda Katz (wycats)
Can be applied to master cleanly. All tests pass on AR suite.
-
Repository
- State changed from verified to resolved
(from [fc6746fc3f102029020e3893cde5480a58470d59]) PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [#3237 state:resolved]
Signed-off-by: wycats wycats@gmail.com
http://github.com/rails/rails/commit/fc6746fc3f102029020e3893cde548... -
Repository
(from [cec44f58388755dec8d4e739e0a3bc3263a7fe3f]) PostgreSQL adapter: escape_bytea, quote_string and unescape_bytea aren't thread-safe in Ruby 1.8 [#3237 state:resolved]
Signed-off-by: wycats wycats@gmail.com
http://github.com/rails/rails/commit/cec44f58388755dec8d4e739e0a3bc... -
