This project is archived and is in readonly mode.
[PATCH] Prefer tap over returning in ActiveSupport
#3281
ActiveSupport's returning function has been replaced by object#tap whenever was possible.
I've attached a patch to start using tap in those areas of ActiveSupport that were still using returning.
Notice that there are two different patches, one for master and the other for 2-3-stable.
-
Gaius Centus Novus+1 and verified in 2.3 stable
-
Gaius Centus Novus
- Tag changed from activesupport, bugmash, patch to 2-3-stable, activesupport, bugmash, patch
- Title changed from Prefer tap over returning in ActiveSupport to [PATCH] Prefer tap over returning in ActiveSupport
-
Rizwan Reza- Tag changed from 2-3-stable, activesupport, bugmash, patch to 2-3-stable, activesupport, patch
-
Rohit Arondekar- State changed from new to stale
- Importance changed from to
The file this patch was provided for has changed considerably.
Master: http://github.com/smtlaissezfaire/rails/blob/2d233ebdcf0de9e769da52...
2-3-stable: http://github.com/smtlaissezfaire/rails/blob/2-3-stable/activesuppo...
Closing ticket as stale. Matias, if this is still an issue please make a comment to reopen and I'll oblige.
-
-
Ryan Bigg
- State changed from stale to resolved