This project is archived and is in readonly mode.

#3282 ✓stale
Gaius Centus Novus

[PATCH] Auto-load i18n configurations for all plugins, not just engines

Reported by Gaius Centus Novus | September 27th, 2009 @ 10:51 PM

Many plugins, especially those that define helper methods for ActionView views, will want to define I18n locale information. Currently the plugin loader only checks for files under {plugin_dir}/config/locales/ for engines. This patch supports config/locales directories for all plugins.

I tested it against 2.3 stable on Ruby 1.8.6.

Comments and changes to this ticket

  • Gaius Centus Novus

    Gaius Centus Novus September 27th, 2009 @ 10:51 PM

    • Tag changed from 2-3-stable, i18n, loader, patch, plugins to 2-3-stable, bugmash, i18n, loader, patch, plugins
  • Blue Box Stephen

    Blue Box Stephen September 28th, 2009 @ 01:08 AM

    +1 to Gaius change idea, but the patch included above doesn't appear to apply cleanly to 2-3-stable (and is missing a path). I've attached a patch. It corrects the aforementioned errors and should apply to 2-3-stable.

  • Gaius Centus Novus

    Gaius Centus Novus September 28th, 2009 @ 01:28 AM

    Weird; I must've diff'd from the wrong directory.

    +1 to Blue Box Stephen's version -- it does exactly what I had intended.

  • Rizwan Reza

    Rizwan Reza February 12th, 2010 @ 12:46 PM

    • Tag changed from 2-3-stable, bugmash, i18n, loader, patch, plugins to 2-3-stable, i18n, loader, patch, plugins
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:55 PM

    • State changed from “new” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:55 PM

    • State changed from “open” to “stale”
  • klkk

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages