This project is archived and is in readonly mode.
HTML::Document#initialize Node.parse call missing strict argument
-
DHH
Could you post the exceptions you're seeing?
-
Jimmy Baker
Certainly. The following pastie shows my code and the exceptions that are produced from it:
-
jdwyah
+1. Google Website Optimizer script tags break my assert_select calls without this.
-
Jeremy Kemper
- Milestone set to 2.1.1
- State changed from new to open
- Assigned user set to Jeremy Kemper
-
Jeremy Kemper
- State changed from open to incomplete
The change looks good, but needs test coverage.
Could you write up a patch with a test case?
-
Jimmy Baker
Absolutely! Stay tuned..
-
Jimmy Baker
Patch attached. The patch includes the fix along with two tests.
-
Jeremy Kemper
- State changed from incomplete to open
Thanks! Want to adjust your email address in your global git config and resubmit before I apply?
-
Jimmy Baker
Oops! Thanks for noticing. Email updated. The revised patch is attached.
-
Repository
- State changed from open to resolved
(from [02ffbc27637db50b7c663d367d0f4712738b0aae]) Patched HTML::Document#initialize call to Node.parse so that it includes the strict argument. [#330 state:resolved]
