Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] re-enable send_file(path, :stream => true)

#3349

3.0.pre disables send_file(path, :stream => true) temporary.
There is a comment in actionpack/lib/action_controller/metal/streaming.rb:
# TODO : Make render :text => proc {} work with the new base

The attached patch re-supports :text => proc {} and re-enables :stream => true option.

Reported by Kouhei Sutou · October 8th, 2009 @ 09:54 AM

State: resolved
Milestone: 3.0.2
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: High

Activity

  1. Kouhei Sutou
    Kouhei Sutou

    October 8th, 2009 @ 09:55 AM

  2. Kouhei Sutou
    Kouhei Sutou
    • Title changed from re-enable send_file(path, :stream => true) to [PATCH] re-enable send_file(path, :stream => true)

    October 9th, 2009 @ 01:04 AM

  3. Ivan Ukhov
    Ivan Ukhov

    Still an issue in beta1 (

    February 22nd, 2010 @ 11:31 PM

  4. José Valim
    José Valim
    • Assigned user set to Yehuda Katz (wycats)
    • Milestone cleared.

    February 23rd, 2010 @ 07:26 AM

  5. Yehuda Katz (wycats)
    Yehuda Katz (wycats)
    • State changed from new to resolved

    This is fixed in master by using the Rack::Sendfile middleware. http://github.com/rails/rails/commit/5e2bd08023344f3fd4675e80203a10...

    February 24th, 2010 @ 05:41 AM

  6. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to High

    October 15th, 2010 @ 11:01 PM