This project is archived and is in readonly mode.
attr_readonly not set when counter_cache set to true
-
Michael Koziarski
Could you add the tests to the .patch you've attached please? Two style issues
if (reflection.klass rescue nil) and reflection.klass.respond_to?(:attr_readonly)Why do you need the rescue there, and trailing conditionals shouldn't be that long, rewrite it to if ... end instead.
Cheers!
-
Rohit Arondekar
- State changed from incomplete to stale
- Tag set to activerecord, patch
- Importance changed from to
Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.