This project is archived and is in readonly mode.
Bignum IDs crash association destroy
Foo.new(:id => 777777777777777777, :bar_id =>
1).save!
Bar.find(1).foos.destroy(777777777777777777) # raises error here, expected Foo(id, bar_id), got Bignum
When using IDs with a value over the 31 bit fixnum limit, the ActiveRecord::Association::AssociationCollection#destroy method does not do a find(id) where it should.
-
Justin George- Tag changed from activerecord, associations, bignum, destroy, fixnum to 2.3.4, activerecord, associations, bignum, destroy, fixnum
Working on getting a test for this, it's difficult to create bignums from scratch across all the different databases.
-
Ryan Bigg- Tag changed from 2.3.4, activerecord, associations, bignum, destroy, fixnum to 2.3.4, activerecord, associations, bignum, bugmash, destroy, fixnum
- State changed from new to open
I cannot duplicate this on 2.3.5. What's the news on this?
-
Santiago Pastorino
- Tag changed from 2.3.4, activerecord, associations, bignum, bugmash, destroy, fixnum to 234, activerecord, associations, bignum, bugmash, destroy, fixnum
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale