This project is archived and is in readonly mode.
Some assertions for the testing of ActionView::TestCase are worthless
In view/test_case_test.rb there are several assertions of this form:
assert 'Holla!', from_shared_helper
How useful is that?!
Attached is a patch that makes more meaningful assertions. For example:
assert_equal 'Holla!', from_shared_helper
The patch applies to 2-3-stable.
For those following along, the good news is that after strengthening the assertions, all tests still pass. At least on 2-3-stable.
-
fix_worthless_assertions.diff
6.98 KB
-
Chris HapgoodLooks like I doubled up the original patch. Here is the proper one.
-
fix_worthless_assertions.diff
1.78 KB
-
-
Eloy Duran- State changed from new to verified
- Milestone set to 2.3.6
- Assigned user set to Eloy Duran
Yup, they're worthless. Applied them in our repo, which will be merged in the main repo in a short while. http://github.com/Fingertips/rails/commit/df9a47e4b8f12a8ecf3001a93...
Gonna look at your other ticket now, thanks.
-
Repository- State changed from verified to resolved
(from [df9a47e4b8f12a8ecf3001a93ab7ba5cefdc9467]) Make some assertions in the ActionView::TestCase tests actually do something.
[#3468 Some assertions for the testing of ActionView::TestCase are worthless state:resolved]
Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/df9a47e4b8f12a8ecf3001a93ab7ba... -
Repository
(from [b43964d6061f4a31320906172f763dd3dd188f4d]) Make some assertions in the ActionView::TestCase tests actually do something.
[#3468 Some assertions for the testing of ActionView::TestCase are worthless state:resolved]
Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/b43964d6061f4a31320906172f763d...