This project is archived and is in readonly mode.

#3468 ✓resolved
Chris Hapgood

Some assertions for the testing of ActionView::TestCase are worthless

Reported by Chris Hapgood | November 6th, 2009 @ 10:35 PM | in 2.3.6

In view/test_case_test.rb there are several assertions of this form:

assert 'Holla!', from_shared_helper

How useful is that?!

Attached is a patch that makes more meaningful assertions. For example:

assert_equal 'Holla!', from_shared_helper

The patch applies to 2-3-stable.

For those following along, the good news is that after strengthening the assertions, all tests still pass. At least on 2-3-stable.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket