Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

escape_javascript can't handle unicode linebreaks (hex E280A8)

#3578

I believe escape_javascript is not properly escaping unicode line breaks.

I've attached a JS file that was generated using escape_javascript directly from my utf8 encoded database. It has the offending character on position 32 of line 1. Try pasting it into the firebug console and you'll get an error "unterminated string literal". Remove character 32, and it fixes it.

I pasted the character into a hex editor and it turns out to be E280A8, which googling leads me to believe is a unicode linebreak.

Modifying the escape_javascript method to include the weird character seems to fix things.

I'm running Ruby 1.8.6

Reported by subimage · December 15th, 2009 @ 11:44 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Michael Kintzer
    Michael Kintzer

    +1 on this issue. I've run into the identical error.

    January 26th, 2010 @ 09:02 PM

  2. Reinier Balt
    Reinier Balt

    I had the same problem. I found that my text is correctly stored in the database (mysql), but it was incorrectly generated in the js resulting in an unwanted line ending in my js

    I solved this by adding

    encoding: utf8

    to my database.yml. Then rails correctly handles the utf8 in my database and handles the linebreak correctly. The generated js does not contain unwanted line endings anymore and characters like é show up correctly (instead of a ?). See http://oldwiki.rubyonrails.org/rails/pages/HowToUseUnicodeStrings under "Configuring the database connection"

    January 12th, 2011 @ 07:57 PM

  3. rails
    rails
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    April 13th, 2011 @ 01:00 AM

  4. rails
    rails
    • State changed from open to stale

    April 13th, 2011 @ 01:00 AM