This project is archived and is in readonly mode.

#3578 ✓stale
subimage

escape_javascript can't handle unicode linebreaks (hex E280A8)

Reported by subimage | December 15th, 2009 @ 11:44 PM

I believe escape_javascript is not properly escaping unicode line breaks.

I've attached a JS file that was generated using escape_javascript directly from my utf8 encoded database. It has the offending character on position 32 of line 1. Try pasting it into the firebug console and you'll get an error "unterminated string literal". Remove character 32, and it fixes it.

I pasted the character into a hex editor and it turns out to be E280A8, which googling leads me to believe is a unicode linebreak.

Modifying the escape_javascript method to include the weird character seems to fix things.

I'm running Ruby 1.8.6

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Shared Ticket Bins

People watching this ticket

Attachments

Pages