This project is archived and is in readonly mode.
[PATCH] ActiveRecord transaction sometimes throw the wrong exception
We're seeing a problem in one of our applications under Postgres whereby exceptions thrown during transactions are being logged as nil RuntimeErrors. Consequently we never actually get the original exception from the transaction and makes root cause analysis "hard."
The rescue block attempts to re-raise the last exception but first checks that the original exception is of a certain type. Since that check is always happening it should always ensure it's returning that original exception.
The attached patch explicitly returns the original exception.
-
John Pignata- Title changed from ActiveRecord transaction sometimes throw the wrong exception to [PATCH] ActiveRecord transaction sometimes throw the wrong exception
-
John Pignata
- Tag changed from activerecord, postgres, transaction to activerecord, bugmash, postgres, transaction
-
Rizwan Reza- Tag changed from activerecord, bugmash, postgres, transaction to activerecord, postgres, transaction
-
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale