This project is archived and is in readonly mode.
ActiveRecord::Relation#to_a should be cachable
#3594
Hey,
Right now there's performance issue in ActiveRecord::Relation#to_a:
@posts = Post.all { ... }
Returns a relation. Ok, then if we do something like:
@posts.map { ... }
Relation#to_a gets called and the records are initialized and loaded, this is ok, but if we do:
@posts.each { ... }
The records will be initialized all over again. This patch fixes this by adding memoization to Relation#to_a and unmemoizing when Base#all gets called.
@posts = Post.all
@posts.map { ... } # All records
@posts = Post.all :limit => 1
@posts.map { ... } # Only the first record
-
memoize_ar_relation_to_a.diff
1.96 KB
-
David Trasbo- Assigned user set to Ryan Bigg
This has been solved - not by using memoization though:
def to_a return @records if loaded? @records = eager_loading? ? find_with_associations : @klass.find_by_sql(arel.to_sql) # ... @loaded = true @records end def loaded? @loaded endThis ticket can be closed.
-
Emilio Tagua- State changed from new to resolved
- Assigned user changed from Ryan Bigg to Emilio Tagua