Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

This project is archived and is in readonly mode.

ActiveRecord: LoadError should be handled more carefully

#3611

I had some problems loading an activerecord connection adapter. AR constantly raised an error telling me to install the gem in question. It feels like 2357 times I checked it and the load paths and anything. Until I found that the load error was not raised by the require statement that loaded the adapter but inside one of the loaded library which was missing something.

This code should check what could not be loaded.
(active_record/connection_adapters/abstract/connection_specification.rb starting at line 68)

begin
  require 'rubygems'
  gem "activerecord-#{spec[:adapter]}-adapter"
  require "active_record/connection_adapters/#{spec[:adapter]}_adapter"
rescue LoadError
  begin
    require "active_record/connection_adapters/#{spec[:adapter]}_adapter"
  rescue LoadError
    raise "Please install the #{spec[:adapter]} adapter: `gem install activerecord-#{spec[:adapter]}-adapter` (#{$!})"
  end
end

I should mention that this problem occurred in an environment without rubygems (jruby loading from jar).

Reported by Martin Vielsmaier · December 23rd, 2009 @ 11:23 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. Ryan Bigg
    Ryan Bigg

    Please turn this into a patch if you wish for it to be applied.

    June 13th, 2010 @ 06:27 AM

  2. Santiago Pastorino
  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open
    • Importance changed from to Low

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 05:02 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 05:02 PM