This project is archived and is in readonly mode.
Inflector.underscore does unnecessary string copies
#3626
The method uses gsub multiple times, which does unnecessary string copies.
Patch fixes this. No tests need updating. Benchmarks shows the new method is about twice as fast.
-
Aaron Pattersonplus one
-
Joe Van DykExact patch, but fixed the author's name and email in the commit log.
-
Yaroslav Markin- Tag changed from 2-3-stable, activesupport to 2-3-stable, activesupport, patch
-
Yaroslav Markin
- Assigned user set to José Valim
-
Repository- State changed from new to resolved
(from [ccf33660a1548dadd123a92df6de2de946d208c4]) Avoid unnecessary allocations in Inflector.underscore [#3626 Inflector.underscore does unnecessary string copies state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/ccf33660a1548dadd123a92df6de2d...