This project is archived and is in readonly mode.

#3648 ✓stale

remote_function :confirm should allow escaping for customizations of messages...

Reported by lateralpunk | January 4th, 2010 @ 07:59 AM

I want to allow allow custom confirm message dialog boxes for all functions dependent on remote_function. e.g.

submit_to_remote ... :confirm=>"5+5"

This should pop a dialog box with the question "10" not "5+5".

I think the fix for
function = "if (confirm('#{escape_javascript(options[:confirm])}')) { #{function}; }" if options[:confirm]

is a combination of removing the single quotes and calling eval()

Basically having variable confirmation boxes allows for example to pass in model data that the user can directly read on the dialog box before the go ahead with the request

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:44 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:44 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket