#3718 [PATCH] vendored_test failures key is required to write a cookie - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3718 ✓committed

[PATCH] vendored_test failures key is required to write a cookie

Reported by Santiago Pastorino | January 17th, 2010 @ 04:16 AM | in 3.0.2


Loaded suite test/plugins/vendored_test
Started
..E..E............
Finished in 39.412021 seconds.

  1) Error:
test_if_specified,_only_those_plugins_are_loaded(PluginsTest::VendoredOrderingTest):
ActiveSupport::Testing::RemoteError: caught ArgumentError: A key is required to write a cookie containing the session data. Use config.action_controller.session = { :key => "_myapp_session", :secret => "some secret phrase" } in config/application.rb
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:178:in `ensure_session_key'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:88:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/inflector/methods.rb:101:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:105:in `app'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:120
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `instance_exec'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:67:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:38:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/tmp/app/config/environment.rb:5
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    test/plugins/vendored_test.rb:163:in `boot_rails'
    test/plugins/vendored_test.rb:173:in `test_if_specified,_only_those_plugins_are_loaded'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:60:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:98:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `fork'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:58:in `run'

  2) Error:
test_the_plugins_are_initialized_in_the_order_they_are_specified(PluginsTest::VendoredOrderingTest):
ActiveSupport::Testing::RemoteError: caught ArgumentError: A key is required to write a cookie containing the session data. Use config.action_controller.session = { :key => "_myapp_session", :secret => "some secret phrase" } in config/application.rb
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:178:in `ensure_session_key'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:88:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/inflector/methods.rb:101:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:105:in `app'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:120
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `instance_exec'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:67:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:38:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/tmp/app/config/environment.rb:5
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    test/plugins/vendored_test.rb:163:in `boot_rails'
    test/plugins/vendored_test.rb:179:in `test_the_plugins_are_initialized_in_the_order_they_are_specified'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:60:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:98:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `fork'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:58:in `run'

18 tests, 18 assertions, 0 failures, 2 errors

Comments and changes to this ticket

Santiago Pastorino January 17th, 2010 @ 04:49 AM
The bug is produced when there's no :all option on config.plugins line
Santiago Pastorino January 17th, 2010 @ 06:25 AM
This patch make tests pass but the method plugins has a huge TODO: fix this method so i suppose that you'll rebuild some part of that or kinda ...
- plugins.patch 1006 Bytes
Anuj Dutta January 17th, 2010 @ 06:27 AM
+1 for the patch.

Applies on master.
Rizwan Reza January 17th, 2010 @ 08:13 AM
- Tag changed from “failing, testing, vendor” to “3.0, failing, patch, testing, vendor”
- Title changed from “vendored_test failures key is required to write a cookie” to “[PATCH] vendored_test failures key is required to write a cookie”
José Valim January 17th, 2010 @ 02:07 PM
- Assigned user set to “Carl Lerche”
The patch is just loading all Railtie plugins all the time, it's not the proper fix. Assigning to Carl.
Santiago Pastorino January 17th, 2010 @ 02:30 PM
Test cases fixed
- plugins.patch 1.3 KB
Rizwan Reza January 17th, 2010 @ 06:46 PM
+1 Verified. Applies cleanly.
José Valim January 18th, 2010 @ 08:06 PM
- Milestone cleared.
Repository January 20th, 2010 @ 02:03 PM
(from [d1ffc54c06fbacf46783f5ebc84bc125c9188fd1]) fixes the failure of config.plugins without :all option tests [#3718 status:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d1ffc54c06fbacf46783f5ebc84bc1...
José Valim January 20th, 2010 @ 02:04 PM
- State changed from “new” to “committed”
- Assigned user changed from “Carl Lerche” to “José Valim”
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Shared Ticket Bins (Sort)

↓↑ drag 455 Open Bugs
↓↑ drag 0 Recent Open Tickets
↓↑ drag 87 Open Patches
↓↑ drag 0 Open Doc Patches
↓↑ drag 542 Stale Tickets
↓↑ drag 3 Verified Patches
↓↑ drag 87 Stale Patches
↓↑ drag 0 Yesterday's Tickets
↓↑ drag 0 Two Days Ago
↓↑ drag 0 This Week
↓↑ drag 0 Last Week
↓↑ drag 7 Bugmash
↓↑ drag 0 Bugmash review queue
↓↑ drag 5 Rails 3 High Priority Tickets

People watching this ticket

Attachments

plugins.patch 1006 Bytes
plugins.patch 1.3 KB

Referenced by

3718 [PATCH] vendored_test failures key is required to write a cookie (from [d1ffc54c06fbacf46783f5ebc84bc125c9188fd1]) fixes t...

Rails Ruby on Rails → 3.0.2

[PATCH] vendored_test failures key is required to write a cookie

Comments and changes to this ticket

Santiago Pastorino January 17th, 2010 @ 04:49 AM

Santiago Pastorino January 17th, 2010 @ 06:25 AM

Anuj Dutta January 17th, 2010 @ 06:27 AM

Rizwan Reza January 17th, 2010 @ 08:13 AM

José Valim January 17th, 2010 @ 02:07 PM

Santiago Pastorino January 17th, 2010 @ 02:30 PM

Rizwan Reza January 17th, 2010 @ 06:46 PM

José Valim January 18th, 2010 @ 08:06 PM

Repository January 20th, 2010 @ 02:03 PM

José Valim January 20th, 2010 @ 02:04 PM

Jeremy Kemper October 15th, 2010 @ 11:01 PM

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Attachments

Tags

Referenced by

Pages

Rails Ruby on Rails → 3.0.2

Keyword searching

[PATCH] vendored_test failures key is required to write a cookie

Comments and changes to this ticket

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Attachments

Tags

Referenced by

Pages