This project is archived and is in readonly mode.

[PATCH] vendored_test failures key is required to write a cookie

#3718


Loaded suite test/plugins/vendored_test
Started
..E..E............
Finished in 39.412021 seconds.

  1) Error:
test_if_specified,_only_those_plugins_are_loaded(PluginsTest::VendoredOrderingTest):
ActiveSupport::Testing::RemoteError: caught ArgumentError: A key is required to write a cookie containing the session data. Use config.action_controller.session = { :key => "_myapp_session", :secret => "some secret phrase" } in config/application.rb
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:178:in `ensure_session_key'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:88:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/inflector/methods.rb:101:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:105:in `app'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:120
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `instance_exec'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:67:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:38:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/tmp/app/config/environment.rb:5
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    test/plugins/vendored_test.rb:163:in `boot_rails'
    test/plugins/vendored_test.rb:173:in `test_if_specified,_only_those_plugins_are_loaded'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:60:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:98:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `fork'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:58:in `run'

  2) Error:
test_the_plugins_are_initialized_in_the_order_they_are_specified(PluginsTest::VendoredOrderingTest):
ActiveSupport::Testing::RemoteError: caught ArgumentError: A key is required to write a cookie containing the session data. Use config.action_controller.session = { :key => "_myapp_session", :secret => "some secret phrase" } in config/application.rb
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:178:in `ensure_session_key'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/session/cookie_store.rb:88:in `initialize'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `new'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:72:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/inflector/methods.rb:101:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `inject'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/middleware/stack.rb:116:in `build'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:105:in `app'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:120
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `instance_exec'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:29:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:67:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `each'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/initializable.rb:66:in `run_initializers'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:38:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `__send__'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/lib/rails/application.rb:12:in `initialize!'
    /home/santiago/Documentos/WyeWorks/Proys/rails/railties/tmp/app/config/environment.rb:5
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    /usr/local/lib/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    test/plugins/vendored_test.rb:163:in `boot_rails'
    test/plugins/vendored_test.rb:179:in `test_the_plugins_are_initialized_in_the_order_they_are_specified'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:60:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:98:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `fork'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:95:in `run_in_isolation'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/isolation.rb:58:in `run'

18 tests, 18 assertions, 0 failures, 2 errors

Reported by Santiago Pastorino · January 17th, 2010 @ 04:16 AM

Activity

Santiago Pastorino
The bug is produced when there's no :all option on config.plugins line

January 17th, 2010 @ 04:49 AM
Santiago Pastorino
This patch make tests pass but the method plugins has a huge TODO: fix this method so i suppose that you'll rebuild some part of that or kinda ...
- plugins.patch 1006 Bytes
January 17th, 2010 @ 06:25 AM
Anuj Dutta
+1 for the patch.

Applies on master.

January 17th, 2010 @ 06:27 AM
Rizwan Reza
- Tag changed from failing, testing, vendor to 3.0, failing, patch, testing, vendor
- Title changed from vendored_test failures key is required to write a cookie to [PATCH] vendored_test failures key is required to write a cookie
January 17th, 2010 @ 08:13 AM
José Valim
- Assigned user set to Carl Lerche
The patch is just loading all Railtie plugins all the time, it's not the proper fix. Assigning to Carl.

January 17th, 2010 @ 02:07 PM
Santiago Pastorino
Test cases fixed
- plugins.patch 1.26 KB
January 17th, 2010 @ 02:30 PM
Rizwan Reza
+1 Verified. Applies cleanly.

January 17th, 2010 @ 06:46 PM
José Valim
- Milestone cleared.
January 18th, 2010 @ 08:06 PM
Repository

(from [d1ffc54c06fbacf46783f5ebc84bc125c9188fd1]) fixes the failure of config.plugins without :all option tests [#3718 [PATCH] vendored_test failures key is required to write a cookie status:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d1ffc54c06fbacf46783f5ebc84bc1...

January 20th, 2010 @ 02:03 PM
José Valim
- State changed from new to committed
- Assigned user changed from Carl Lerche to José Valim
January 20th, 2010 @ 02:04 PM
Jeremy Kemper
- Milestone set to 3.0.2
- Importance changed from to Low
[bulk edit]

October 15th, 2010 @ 11:01 PM