This project is archived and is in readonly mode.
[PATCH(es)] JavaScript: multiple fixes for jQuery & Prototype drivers
Reported by Quin Hoxie | January 28th, 2010 @ 10:43 AM | in 3.0.2
There were a number of issues in the javascript framework drivers. Some are minor, some are not. They range from missing semicolons to incorrect conditions. The commits are broken up logically, and I have the patches broken out if necessary.
Comments and changes to this ticket
-
Rizwan Reza January 28th, 2010 @ 02:06 PM
- Milestone cleared.
I talked to stevestmartin on this one, who's been working on bringing UJS to Rails 3. He is not sure why you took off the minified version of jQuery. Please resubmit your patch without changing the jQuery library itself.
-
Quin Hoxie January 28th, 2010 @ 07:20 PM
Hi Rizwan,
As I noted in the commit message, this is for symmetry with the prototype include, which is not minified. Since this is a distribution of a development framework, and we are including a development library (jQuery), I believe that the way prototype is included is correct. Libraries should not be minified in development - that is a deployment decision.
-Quin
-
Rizwan Reza January 28th, 2010 @ 07:38 PM
Thanks for responding Quin. When I talked to stevestmartin about this, he said that the javascript code is a proof of concept at the moment. I think he can respond on this one in a better way but I think it makes sense to go with the minified version unless a user explicitly includes the development version.
-
Quin Hoxie January 28th, 2010 @ 07:49 PM
I think the primary issue is symmetry; the rest is certainly subjective. Really, it should probably follow a similar path as something like Rails' class caching and whiny nils - both minified and raw are distributed, and raw is used in development.
I have the split out patches, but I'm currently at work, so I'll upload them when I get home.
-
Quin Hoxie January 29th, 2010 @ 06:58 AM
- no changes were found...
-
Steve St. Martin February 1st, 2010 @ 05:52 AM
- Tag changed from “javascript, jquery, prototype, rails3” to “invalid, javascript, jquery, prototype, rails3”
Both drivers have since been rewritten, making these patches obsolete.
-
Rizwan Reza February 1st, 2010 @ 06:43 AM
- State changed from “new” to “invalid”
-
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Quin Hoxie
Steve St. Martin