Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH(es)] JavaScript: multiple fixes for jQuery & Prototype drivers

#3805

There were a number of issues in the javascript framework drivers. Some are minor, some are not. They range from missing semicolons to incorrect conditions. The commits are broken up logically, and I have the patches broken out if necessary.

Reported by Quin Hoxie · January 28th, 2010 @ 10:43 AM

State: invalid
Milestone: 3.0.2
Assigned to: nobody
Importance: Low

Activity

  1. Rizwan Reza
    Rizwan Reza
    • Milestone cleared.

    I talked to stevestmartin on this one, who's been working on bringing UJS to Rails 3. He is not sure why you took off the minified version of jQuery. Please resubmit your patch without changing the jQuery library itself.

    January 28th, 2010 @ 02:06 PM

  2. Quin Hoxie
    Quin Hoxie

    Hi Rizwan,

    As I noted in the commit message, this is for symmetry with the prototype include, which is not minified. Since this is a distribution of a development framework, and we are including a development library (jQuery), I believe that the way prototype is included is correct. Libraries should not be minified in development - that is a deployment decision.

    -Quin

    January 28th, 2010 @ 07:20 PM

  3. Rizwan Reza
    Rizwan Reza

    Thanks for responding Quin. When I talked to stevestmartin about this, he said that the javascript code is a proof of concept at the moment. I think he can respond on this one in a better way but I think it makes sense to go with the minified version unless a user explicitly includes the development version.

    January 28th, 2010 @ 07:38 PM

  4. Quin Hoxie
    Quin Hoxie

    I think the primary issue is symmetry; the rest is certainly subjective. Really, it should probably follow a similar path as something like Rails' class caching and whiny nils - both minified and raw are distributed, and raw is used in development.

    I have the split out patches, but I'm currently at work, so I'll upload them when I get home.

    January 28th, 2010 @ 07:49 PM

  5. Quin Hoxie
  6. Steve St. Martin
    Steve St. Martin
    • Tag changed from javascript, jquery, prototype, rails3 to invalid, javascript, jquery, prototype, rails3

    Both drivers have since been rewritten, making these patches obsolete.

    February 1st, 2010 @ 05:52 AM

  7. Rizwan Reza
    Rizwan Reza
    • State changed from new to invalid

    February 1st, 2010 @ 06:43 AM

  8. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM