#3849 [PATCH] Fixed missing newline characters after gem and add_source generator actions - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3849 ✓resolved

[PATCH] Fixed missing newline characters after gem and add_source generator actions

Reported by Lucas Efe | February 4th, 2010 @ 02:30 PM

A generator that uses the "gem" or "add_source" actions, when executed, it generates the Gemfile wrong. It concatenate the lines, without adding the newline character at the end of the line.

You get something like this:

# Gemfile
gem "rake",  ">= 0.8.7"gem "mocha", ">= 0.9.8"

instead of

# Gemfile
gem "rake",  ">= 0.8.7"
gem "mocha", ">= 0.9.8"

Same happens if you use add_source.

This patch fixes this issue.

Comments and changes to this ticket

You flagged this item as spam.
Lucas Efe February 4th, 2010 @ 02:31 PM
- Tag set to “rails 3.0 generators”
Looks like I forgot to include the diff file.
- missing_newlines_on_generator_actions.diff 2.2 KB
Rohit Arondekar October 7th, 2010 @ 11:28 AM
- State changed from “new” to “resolved”
- Importance changed from “” to “Low”
This is no longer an issue. It must have been fixed along the way.