This project is archived and is in readonly mode.

#3962 ✓stale
Paweł Gościcki

url_for fails for a RESTful resource composed of a composite key (not just the id)

Reported by Paweł Gościcki | February 15th, 2010 @ 10:50 AM

Given the following resource definition:

map.resources :posts, :except => [:show]
match '/:year/:month/:slug', :to => "posts#show", :as => :post

This does not work:

<%= link_to @post.title, @post %>

Currently it throws this error:

No route matches {:year=>#<Post id: 1, title: "test", (...)>, :controller=>"posts", :action=>"show"}

The Post object (!) is assigned to the first route paramter (:year), which is totally incorrect. That's a bug.

I know the recommended way to construct urls is to use a parameters Hash, like this:

<%= link_to @post.title, post_url(:year => '2010', :month => '02', :slug => 'test') %>

But in my opinion it should be possible to use just url_for(@post). It should call @post.to_param or similar (which would return the required hash).

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:55 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:55 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages