This project is archived and is in readonly mode.
ActiveRecord attribute accessor String, and Element Reference []
Reported by Daniel | February 16th, 2010 @ 11:15 PM
Greetings,
There appears to be an easy misunderstanding with the accessor method and the String.
class User << ActiveRecord::Base
end
Having table columns email:string, flags:string
if I set
user = Users(:myuser) # fixture
user.email="ponies@rubyonrails.com"
user.flags[7]="1"
This behaves quite differently.
Changing user.email causes a change in user.@changed_attributes,
and user.@attributes.
But the user.flags[7] causes in user.@attributes, but not
@changed_attributes.
I suspect this is caused by an easy mis-understanding that user.flags is an accessor.
So, the code could be inferred to look like this
(user.flags)[7]="1" Which directly changes the @attributes, but
does not invoke the subroutine to record it in
@changed_attributes.
I suspect the best way to fix this to create a RoRString class with [] overloaded as follows
class RoR_String < String
def []=(var, replace)
super(var, replace)
# call back to record new value in @change_attributes
end end
This seams considerably larger than a patch, since this would
affect all RoR ActiveRecord strings.
Regards,
Daniel Lo
Comments and changes to this ticket
-
Santiago Pastorino February 2nd, 2011 @ 04:54 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:55 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Daniel