Rails Ruby on Rails

Comments and changes to this ticket

• 

  José Valim February 21st, 2010 @ 12:51 PM

  • State changed from “new” to “invalid”

  gsub_file should not ask for file collision. file_collision is done when you are creating a file in a place where another already exists. For instance, scaffold uses gsub_file to add routes to your config/routes.rb. If it asked every time if you want to modify it or not, it would be painful.

  If Cucumber is going risky operation, they should ask their users before:

  if yes?("Do you want to change your database.yml?")
    gsub_file ...
  end
  

  Does it make sense?

• You flagged this item as spam.
  

  Aslak Hellesøy February 21st, 2010 @ 01:23 PM

  Thanks José - I wasn't aware of #yes? - I'll use that.

• 

  José Valim February 21st, 2010 @ 01:33 PM

  You're welcome! Here is a list of methods that comes from Thor:

  http://rdoc.info/rdoc/wycats/thor/blob/4f5da62d135aa10122e8c51f0c0d...

  And here are the ones that Rails adds:

  http://github.com/rails/rails/tree/master/railties/lib/rails/genera...

  Regards!

• You flagged this item as spam.
  

  Sam Goldstein February 21st, 2010 @ 06:24 PM

  I agree that users (e.g. cucumber) should deal with the prompt/confirmation logic for gsub_file since this logic may vary case to case. It would be nice if gsub_file simply output that a change has taken place. Something like:

  changed config/database.yml

  This would help end users of generators know that a file had been changes, especially in cases (like database.yml) where it may be excluded from SCM. It doesn't make sense for each generator to have to roll their own code to tell the user that a file has changed.

• 

  José Valim February 21st, 2010 @ 07:23 PM

  gsub_file does output. Unless you ask not to.