This project is archived and is in readonly mode.

#3982 ✓stale
Jose Fernández

[PATCH] Solved a bug that prevented xml serialization when ActiveRecord attributes contains more than column values

Reported by Jose Fernández | February 17th, 2010 @ 06:08 PM

When ActiveRecord serializes its attributes in xml it computes the type by means of the columns instead of the attributes themselves.

Given that when has_and_belongs_to_many association is used in ActiveRecord, the "join keys" are added to the attributes array of the ActiveRecord object it raises and exception when calling to_xml because ActiveRecord has no idea of the type of these "ghost" attributes.

Different approaches can be used to solve this issue. One could be not to use these keys inside the attributes array. Another approach could be not to rely on the attributes when serializing but on the columns directly, this has the drawback that this part of the code is in ActiveModel so no column assumption can be made.

My approach was to fallback in the same implementation used in MethodAttribute#compute_type so a mapping is taken directly from the class of the object (patch provided).

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:54 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:54 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket