#40 nil default options for file_store - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#40 ✓resolved

nil default options for file_store

Reported by geemus (Wesley Beary) | April 23rd, 2008 @ 12:29 AM

When working with custom caching, I switched from memory_store to file_store and started having a number of errors that I at first assumed were my own. Upon further examination I saw the issues was a "wrong number of parameters 1 for 2" type error on the delete call.

So this patch changes the options parameter to default to nil on delete and delete_matched to be more consistent with the other cache store interfaces.

Comments and changes to this ticket

You flagged this item as spam.
Chad April 23rd, 2008 @ 12:34 AM
+1
You flagged this item as spam.
geemus (Wesley Beary) April 23rd, 2008 @ 12:35 AM
Both patches are the same, accidentally double posted (because I didn't see it appear the first time). Trying to delete visually makes it disappear, but it is still there on refresh.
Michael Koziarski April 23rd, 2008 @ 09:25 AM
Um, the patches are gone now?
You flagged this item as spam.
geemus (Wesley Beary) April 23rd, 2008 @ 05:16 PM
Lighthouse is out to get me! or something.
Sorry about that, re-uploading now.
- fix_default_file_store_options.diff 866 Bytes
You flagged this item as spam.
geemus (Wesley Beary) April 25th, 2008 @ 07:06 PM
Updating rails re-broke this for me today, anything else I can do to help get this in? Ie, poke? I think with the patch attached now it should be good to go, tests pass, etc.
Repository April 26th, 2008 @ 01:22 AM
(from [f3fd44f76b64d6c30967a31b91709d27bce41f72]) Add default options to file_store to make it align with the other cache stores. [monki]
[#40 state:resolved]
http://github.com/rails/rails/co...
Michael Koziarski April 26th, 2008 @ 01:24 AM
- State changed from “new” to “resolved”
I've applied this now.
If you want to have your name and email show up in the logs, you'll need to use git format-patch --stdout. But thanks for the fix in the meantime :)
You flagged this item as spam.
geemus (Wesley Beary) April 26th, 2008 @ 08:42 PM
Right. Still trying to get the hang of this git business. [monki] is good enough for this time, I'll know better next time.