Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

nil default options for file_store

#40

When working with custom caching, I switched from memory_store to file_store and started having a number of errors that I at first assumed were my own. Upon further examination I saw the issues was a "wrong number of parameters 1 for 2" type error on the delete call.

So this patch changes the options parameter to default to nil on delete and delete_matched to be more consistent with the other cache store interfaces.

Reported by geemus (Wesley Beary) · April 23rd, 2008 @ 12:29 AM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Chad
    Chad

    +1

    April 23rd, 2008 @ 12:34 AM

  2. geemus (Wesley Beary)
    geemus (Wesley Beary)

    Both patches are the same, accidentally double posted (because I didn't see it appear the first time). Trying to delete visually makes it disappear, but it is still there on refresh.

    April 23rd, 2008 @ 12:35 AM

  3. Michael Koziarski
    Michael Koziarski

    Um, the patches are gone now?

    April 23rd, 2008 @ 09:25 AM

  4. geemus (Wesley Beary)
    geemus (Wesley Beary)

    Lighthouse is out to get me! or something.

    Sorry about that, re-uploading now.

    April 23rd, 2008 @ 05:16 PM

  5. geemus (Wesley Beary)
    geemus (Wesley Beary)

    Updating rails re-broke this for me today, anything else I can do to help get this in? Ie, poke? I think with the patch attached now it should be good to go, tests pass, etc.

    April 25th, 2008 @ 07:06 PM

  6. Repository
    Repository

    (from [f3fd44f76b64d6c30967a31b91709d27bce41f72]) Add default options to file_store to make it align with the other cache stores. [monki]

    [#40 state:resolved]

    http://github.com/rails/rails/co...

    April 26th, 2008 @ 01:22 AM

  7. Michael Koziarski
    Michael Koziarski
    • State changed from new to resolved

    I've applied this now.

    If you want to have your name and email show up in the logs, you'll need to use git format-patch --stdout. But thanks for the fix in the meantime :)

    April 26th, 2008 @ 01:24 AM

  8. geemus (Wesley Beary)
    geemus (Wesley Beary)

    Right. Still trying to get the hang of this git business. [monki] is good enough for this time, I'll know better next time.

    April 26th, 2008 @ 08:42 PM