This project is archived and is in readonly mode.

#4177 ✓committed
Chris Griego

Deprecated framework rake tasks should exit with non-zero exit code

Reported by Chris Griego | March 14th, 2010 @ 07:00 PM | in 3.0.2

The rails:freeze:gems, rails:freeze:edge, and rails:unfreeze tasks have been deprecated in Rails 3.0.0 in favor of Bundler. When executing any of these tasks, they currently output a deprecation message via puts. However, this won't halt the rake execution chain and it doesn't return a non-zero error exit code to the OS level. This means any automated use of these rake tasks will fail silently with only a message that a human must read to notice that they didn't execute properly.

This patch changes the puts to abort so that the rake execution chain is halted and the OS receives an exit code of 1.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages