This project is archived and is in readonly mode.
PostgreSQL: Use all config options in rake db:create and db:test:purge
Reported by Pete Deffendol | April 23rd, 2008 @ 05:39 PM
"rake db:create" should honor all PostgreSQL database creation options allowed in the adapter's create_database method, and specified in database.yml.
Comments and changes to this ticket
-
Michael Koziarski May 2nd, 2008 @ 11:45 PM
- State changed from “new” to “resolved”
This looks like #86
-
Pete Deffendol May 2nd, 2008 @ 11:58 PM
Yes, but #86 deals with modifying rake db:test:purge to use the create_database method, and this one fixes rake db:create to pass all the database configuration settings instead of just the encoding. (I also have #38 which fixes both of them in the case that there isn't a PostgreSQL database with the same name as the connecting user.)
I was under the impression that separate patches were preferred, although all three (in my opinion) are needed to get working rake tasks. If you would prefer a single patch file, I get submit one.
-
Michael Koziarski May 4th, 2008 @ 01:18 AM
We do generally prefer seperate patches, but with the new git patch methods ( http://rails.lighthouseapp.com/p... ) it's a lot easier.
If you want to tie all the tidying into one postgresql fixes patch, I'd be happy to review and apply.
Thanks again!
-
Pete Deffendol May 4th, 2008 @ 04:46 AM
- Title changed from “PostgreSQL: Use all config options in rake db:create” to “PostgreSQL: Use all config options in rake db:create and db:test:purge”
Alright, attaching a new patch that will handle both this ticket and that described in #86.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Michael Koziarski
Attachments
Referenced by
-
86
PostgreSQL: Use adapter's #create_database db:test:purge
The patch referenced here has been rolled into #42 by re...
-
640
Table columns of type references given wrong name in fixtures
test_truth(CommentTest): ActiveRecord::StatementInvalid:...