Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] link_to :remote => false does not work

#4244

link_to ignores the value of the :remote option, only taking into account if the option is there or not. This patch adds the ability to pass :remote => false in order to decide at runtime if you want the link to be javascript or not.

Reported by foca · March 20th, 2010 @ 08:59 PM

State: resolved
Milestone: 3.0.2
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: Low

Activity

  1. foca
    foca
    • Tag changed from action_view helper patch to action_view, helper, patch

    March 20th, 2010 @ 09:06 PM

  2. Yehuda Katz (wycats)
    Yehuda Katz (wycats)
    • State changed from new to incomplete
    • Assigned user set to Yehuda Katz (wycats)
    • Milestone cleared.

    Shouldn't this also work for other remote types like form_for :remote => false?

    March 27th, 2010 @ 08:22 AM

  3. Yehuda Katz (wycats)
    Yehuda Katz (wycats)
    • Tag changed from action_view, helper, patch to action_view, helper, patch, rails3

    March 27th, 2010 @ 08:22 AM

  4. foca
    foca

    It already works for button_to and form_tag, only link_to was missing.

    March 27th, 2010 @ 06:52 PM

  5. foca
    foca

    Should I add tests for those too, so we don't get a regression?

    March 27th, 2010 @ 06:53 PM

  6. foca
  7. Dan Pickett
    Dan Pickett

    +1 verified the latest patch applies cleanly and results in the intended behavior. New tests were added to ensure no regression took place

    bostonrb

    April 21st, 2010 @ 01:54 AM

  8. Neeraj Singh
  9. Yehuda Katz (wycats)
    Yehuda Katz (wycats)
    • State changed from incomplete to resolved

    May 4th, 2010 @ 05:24 PM

  10. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM