Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Pickett

Dan Pickett

Principal · Member of 1 project: Ruby on Rails

Dan Pickett's latest activity

Wednesday, April 06 2011
6552 Rails 3 has_many through forces developer to make *_id attributes unprotected was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:16 AM

    Dmitry,

    Could you provide a failing test case? I'd be happy to look into it.

    Thanks,
    Dan
6567 [Patch] Failing Test in Railties was updated in Ruby on Rails
Tuesday, March 15 2011
6552 Rails 3 has_many through forces developer to make *_id attributes unprotected was updated in Ruby on Rails
  • Dan Pickett
    • State changed from open to resolved
    by Dan Pickett at 12:57 PM
Monday, March 14 2011
6522 distance_of_time_in_words / time_ago_in_words shouldn't use named arguments was updated in Ruby on Rails
  • Dan Pickett
    • State changed from new to open
    • Assigned user changed from Dan Pickett to Santiago Pastorino
    by Dan Pickett at 4:09 PM

    a model patch. Applies cleanly to master and appears well documented.

    Thanks Clemens. Assigning to Santiago for his review and signoff.
Sunday, March 13 2011
6522 distance_of_time_in_words / time_ago_in_words shouldn't use named arguments was updated in Ruby on Rails
  • Dan Pickett
    • Milestone set to 3.x
    • Assigned user set to Dan Pickett
    • Importance changed from to Low
    by Dan Pickett at 5:32 PM

    I'm +1 on this and it applies cleanly to master, but it creates a lot of noise in the test suite currently. Can you update the test suite to comply with your ne...
4919 distance_of_time_in_words should work with DateTime as argument was updated in Ruby on Rails
  • Dan Pickett
    • Tag changed from datetime time date to datetime, distance_of_time_in_words
    • Milestone set to 3.x
    • Assigned user set to Dan Pickett
    • Importance changed from to Low
    by Dan Pickett at 5:27 PM

    applying this patch causes 3 test failures in actionpack master. Can you fix the patch to include a failing test case without your change and fixes to remedy th...
6081 Rails generate skip and force options not working was updated in Ruby on Rails
  • Dan Pickett
    • Milestone set to 3.x
    by Dan Pickett at 5:10 PM

    MarcRic,

    Do you feel as though documenting the --no-migration option in help would help to clarify this issue, and maybe adding a caveat to the --skip help text...
5322 Rails3 RC - AREL does not work with multiple schemas using MySQL was updated in Ruby on Rails
  • Dan Pickett
    • State changed from new to open
    • Assigned user set to Aaron Patterson
    • Importance changed from to Low
    by Dan Pickett at 3:42 PM
Saturday, March 12 2011
6460 active_support/core_ext/string/inflections doesn't load default inflections was updated in Ruby on Rails
  • Dan Pickett
    • State changed from open to invalid
    by Dan Pickett at 10:36 PM
6552 Rails 3 has_many through forces developer to make *_id attributes unprotected was updated in Ruby on Rails
  • Dan Pickett
    • Tag changed from activerecord rails3 has_many through mass-assignment security attr_accessible to attr_accessible, has_many_through_association, rails3
    • State changed from new to open
    • Assigned user set to Dan Pickett
    • Importance changed from to Low
    by Dan Pickett at 5:41 PM

    based on my reading of the code on edge in has_many_through association it is performing a direct assignment on both ends of the relationship and the assignment...