#4295 Rails incorrectly imposes version number as last part of gem directory name - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4295 ✓resolved

Rails incorrectly imposes version number as last part of gem directory name

Reported by Chris Ochs | March 29th, 2010 @ 07:05 PM | in 2.3.10

Rails requires that gems have a number as the last part of the filename, so many windows gems can't be frozen since the platform string is the last part of the gem name (and directory name)

version_for_dir in VendorGemSourceIndex makes this assumption, as does from_directory_name in GemDependency.

The monkey patch is kind of a pain, as you have to load the patch from two different places in boot.rb.

Comments and changes to this ticket

You flagged this item as spam.
Chris Ochs March 29th, 2010 @ 07:06 PM
Correction, this only applies to frozen gems.
Yehuda Katz (wycats) March 29th, 2010 @ 07:22 PM
- Milestone set to “2.3.6”
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag set to “bugmash”
[bulk edit]
You flagged this item as spam.
Colin Casey May 17th, 2010 @ 02:59 AM
verified
I've attached a test
- test_incorrectly_imposed_version_number_as_last_part_of_gem_dir_name.diff 2.7 KB
You flagged this item as spam.
Colin Casey May 17th, 2010 @ 03:05 AM
- Tag changed from “bugmash” to “bugmash, bugmash-patch, bugmash-review”
Also, I've attached a patch. This patch contains both the test case and the fix so the above patch is unnecessary.
- fix_incorrectly_imposed_version_number_as_last_part_of_gem_dir_name.diff 4.4 KB
Jeff Kreeftmeijer May 17th, 2010 @ 02:54 PM
+1

Applies cleanly to 2-3-stable, tests pass. :)
Jeremy Kemper May 23rd, 2010 @ 05:54 PM
- Milestone changed from “2.3.6” to “2.3.7”
[bulk edit]
Jeremy Kemper May 24th, 2010 @ 09:40 AM
- Milestone changed from “2.3.7” to “2.3.8”
[bulk edit]
Jeremy Kemper May 25th, 2010 @ 11:45 PM
- Milestone changed from “2.3.8” to “2.3.9”
[bulk edit]

Ben Oakes May 26th, 2010 @ 07:46 PM

I'm having the same problem, but it took me a little while to find this ticket. The error message I'm getting is:

Malformed version number string mswin32 (ArgumentError)

Hopefully that makes the ticket easier to search for. :) I had also written up steps to reproduce the bug, which I'm including just for reference:

rails gem_bug_sandbox
cd gem_bug_sandbox
vim config\environment.rb
# # Add a gem with native extensions, such as nokogiri 1.4.2:
# config.gem 'nokogiri', :version => '1.4.2'
rake gems:install
rake gems:unpack

To get the error message:

ruby script\server
=> Booting WEBrick
=> Rails 2.3.5 application starting on http://0.0.0.0:3000
C:/Ruby/lib/ruby/site_ruby/1.8/rubygems/version.rb:107:in `initialize': Malformed version number string mswin32 (ArgumentError)

In the meantime, I'm just not unpacking the problem gems. It's not ideal, but it works.

Rizwan Reza June 13th, 2010 @ 08:16 PM
- Tag changed from “bugmash, bugmash-patch, bugmash-review” to “bugmash-review”
- State changed from “new” to “verified”
Jeremy Kemper August 30th, 2010 @ 02:28 AM
- Milestone changed from “2.3.9” to “2.3.10”
- Importance changed from “” to “Low”
[bulk edit]
David Trasbo September 23rd, 2010 @ 10:52 AM
- Assigned user set to “José Valim”
This patch should really be applied. Perhaps mr. Valim will take care of it?
Repository September 24th, 2010 @ 12:18 PM
- State changed from “verified” to “resolved”
(from [f2990620d716146064d9d2f88ac487025d4b031a]) Test for imposed version number as last part of gem directory name for frozen gems

[#4295 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f2990620d716146064d9d2f88ac487...
You flagged this item as spam.
Ben Oakes September 30th, 2010 @ 12:02 PM
Just curious: how relevant is this ticket with Bundler now being the new hotness? (Does the fix mainly affect Rails 2?)
David Trasbo September 30th, 2010 @ 03:51 PM
Ben,

Actually this change exclusively affects Rails 2.3.x. Rails 2 is maintained even now when Rails 3 is out.
You flagged this item as spam.
Ben Oakes September 30th, 2010 @ 05:00 PM
David,

Good to know. Thanks.