This project is archived and is in readonly mode.
Rails incorrectly imposes version number as last part of gem directory name
-
Chris Ochs
Correction, this only applies to frozen gems.
-
Yehuda Katz (wycats)
- Milestone set to 2.3.6
-
Colin Casey
verified
I've attached a test -
Colin Casey
- Tag changed from bugmash to bugmash, bugmash-patch, bugmash-review
Also, I've attached a patch. This patch contains both the test case and the fix so the above patch is unnecessary.
-
Jeff Kreeftmeijer
+1
Applies cleanly to 2-3-stable, tests pass. :)
-
Ben Oakes
I'm having the same problem, but it took me a little while to find this ticket. The error message I'm getting is:
Malformed version number string mswin32 (ArgumentError)Hopefully that makes the ticket easier to search for. :) I had also written up steps to reproduce the bug, which I'm including just for reference:
rails gem_bug_sandbox cd gem_bug_sandbox vim config\environment.rb # # Add a gem with native extensions, such as nokogiri 1.4.2: # config.gem 'nokogiri', :version => '1.4.2' rake gems:install rake gems:unpackTo get the error message:
ruby script\server => Booting WEBrick => Rails 2.3.5 application starting on http://0.0.0.0:3000 C:/Ruby/lib/ruby/site_ruby/1.8/rubygems/version.rb:107:in `initialize': Malformed version number string mswin32 (ArgumentError)In the meantime, I'm just not unpacking the problem gems. It's not ideal, but it works.
-
Rizwan Reza
- Tag changed from bugmash, bugmash-patch, bugmash-review to bugmash-review
- State changed from new to verified
-
David Trasbo
- Assigned user set to José Valim
This patch should really be applied. Perhaps mr. Valim will take care of it?
-
Repository
- State changed from verified to resolved
(from [f2990620d716146064d9d2f88ac487025d4b031a]) Test for imposed version number as last part of gem directory name for frozen gems
[#4295 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f2990620d716146064d9d2f88ac487... -
Ben Oakes
Just curious: how relevant is this ticket with Bundler now being the new hotness? (Does the fix mainly affect Rails 2?)
-
David Trasbo
Ben,
Actually this change exclusively affects Rails 2.3.x. Rails 2 is maintained even now when Rails 3 is out.
-
Ben Oakes
David,
Good to know. Thanks.
