This project is archived and is in readonly mode.
Parameterize should accept malformated utf8 strings
-
Kristopher Murata
- Tag set to patch
-
Yaroslav Markin
- Tag changed from patch to activesupport, patch, utf8
- Assigned user set to José Valim
Works for me; Need this as well.
-
Jeremy Kemper
- State changed from new to incomplete
- Milestone set to 2.3.6
NoMethodError: undefined method `toutf8' for "Test with malformed utf8 \xA9":String
-
Kristopher Murata
Hi Jeremy,
I think that this problem is due to the missing Kconv module, we can call Kconv directly since the toutf8 method on String is just an alias to Kconv.toutf8().
Also, I see that you marked for the next 2.3.6 release, should I branch from stable 2.3.5 (instead of master) and redo the patch?
-
Jeremy Kemper
Ah ok - be sure to require kconv.
We always work from master, then
git cherry-pickback to 2-3-stable if appropriate. I marked this as 2.3.6 since it'd be a welcome update for 2.3.6 users also. -
Kristopher Murata
Thanks Jeremy.
Ok, attached the fixed patch.
-
Repository
- State changed from incomplete to resolved
(from [ef84e691ffe7b43ce64e859f43b17128a405785a]) Parameterize should accept malformed utf8 characters [#4323 Parameterize should accept malformated utf8 strings state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/ef84e691ffe7b43ce64e859f43b171... -
Jeremy Kemper
- State changed from resolved to incomplete
Kristopher, could you backport to 2-3-stable?
-
Kristopher Murata
Yep, I'm installing ruby 1.9 env to test a particular case on 2-3-stable branch.
-
Kristopher Murata
Ok, attached the patch file for 2-3-stable branch.
-
Repository
- State changed from incomplete to resolved
(from [642d5d297e9569a76047c958b8e4aa23522f300d]) Parameterize should accept malformed utf8 characters [#4323 Parameterize should accept malformated utf8 strings state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/642d5d297e9569a76047c958b8e4aa...
