Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• You flagged this item as spam.
  

  Chetan Sarva April 13th, 2010 @ 04:05 AM

  • Tag set to “patch”

  • 4383-config-perfom_caching.diff 1 KB

• You flagged this item as spam.
  

  Chetan Sarva April 13th, 2010 @ 04:07 AM

  • Tag changed from “patch” to “rails 3.0.0.beta2, edge, patch”

• You flagged this item as spam.
  

  Chetan Sarva April 13th, 2010 @ 04:13 AM

  • Title changed from “config.action_controller.perform_caching has no effect” to “[PATCH] config.action_controller.perform_caching has no effect”

• You flagged this item as spam.
  

  Kristopher Murata April 13th, 2010 @ 04:55 AM

  • Tag changed from “rails 3.0.0.beta2, edge, patch” to “rails 3.0.0.beta2, cache, edge, patch”
  • Assigned user set to “José Valim”

  +1, the patch works for me.

  First I tested here the Rails HEAD with webrick and thin, both are always using cache, even when config.action_controller.perform_caching = false. (I only testes page caching, not fragment)

  But I see that your patch doesn't have any tests, could you add some?

• You flagged this item as spam.
  

  Chetan Sarva April 13th, 2010 @ 04:33 PM

  Added tests as requested. New patch contains fix + tests.

  • 4383-config-perfom_caching-with_tests.diff 2.7 KB
• 

  Repository April 14th, 2010 @ 12:32 AM

  • State changed from “new” to “committed”

  (from [0ab2ba336f2b094a4235b54a1b17f8bef3fe3b2b]) config.perform_caching added to the deprecated config accessor [#4383 state:committed]

  Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
  http://github.com/rails/rails/commit/0ab2ba336f2b094a4235b54a1b17f8...

• 

  Santiago Pastorino April 14th, 2010 @ 01:13 AM

  • Milestone cleared.

  I've kept Chetan Sarva as the committer of the tests

• You flagged this item as spam.
  

  MatthewRudy April 14th, 2010 @ 06:06 AM

  I was looking earlier
  there are still a load of places which reference "perform_caching" directly on ActionController
  namely inside the ActionController::Caching module

  I noticed this when running the ActionDispatch tests on master.
  get a load of "use should be using config.perform_caching" messages.

  But there are so many,
  I'm not familiar enough with the structure to decide what to change.

• You flagged this item as spam.
  

  Chetan Sarva April 14th, 2010 @ 03:14 PM

  It looks like only the tests have been committed so far and not the fix itself -

  http://github.com/rails/rails/commit/90594721779e1d3ab103989fb7d0a7...

• 

  Santiago Pastorino April 14th, 2010 @ 03:16 PM

  The proper fix is here http://github.com/rails/rails/commit/0ab2ba336f2b094a4235b54a1b17f8...

• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”
  • Importance changed from “” to “Low”

  [bulk edit]