This project is archived and is in readonly mode.
[PATCH] config.action_controller.perform_caching has no effect
-
-
Chetan Sarva
- Tag changed from patch to rails 3.0.0.beta2, edge, patch
-
Chetan Sarva
- Title changed from config.action_controller.perform_caching has no effect to [PATCH] config.action_controller.perform_caching has no effect
-
Kristopher Murata- Tag changed from rails 3.0.0.beta2, edge, patch to rails 3.0.0.beta2, cache, edge, patch
- Assigned user set to José Valim
+1, the patch works for me.
First I tested here the Rails HEAD with webrick and thin, both are always using cache, even when config.action_controller.perform_caching = false. (I only testes page caching, not fragment)
But I see that your patch doesn't have any tests, could you add some?
-
Chetan Sarva
Added tests as requested. New patch contains fix + tests.
-
Repository
- State changed from new to committed
(from [0ab2ba336f2b094a4235b54a1b17f8bef3fe3b2b]) config.perform_caching added to the deprecated config accessor [#4383 [PATCH] config.action_controller.perform_caching has no effect state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/0ab2ba336f2b094a4235b54a1b17f8... -
-
MatthewRudy
I was looking earlier
there are still a load of places which reference "perform_caching" directly on ActionController
namely inside the ActionController::Caching moduleI noticed this when running the ActionDispatch tests on master.
get a load of "use should be using config.perform_caching" messages.But there are so many,
I'm not familiar enough with the structure to decide what to change. -
Chetan Sarva
It looks like only the tests have been committed so far and not the fix itself -
http://github.com/rails/rails/commit/90594721779e1d3ab103989fb7d0a7...
-
Santiago Pastorino
The proper fix is here http://github.com/rails/rails/commit/0ab2ba336f2b094a4235b54a1b17f8...
-
