Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] ActionController::TestCase requires Hash#to_query

#4393

I'm trying to commit a patch to ActionPack
but all of the tests are failing

gradually I'm peeling away the reasons.

here's one

  ruPro:~/rails/actionpack$ rake
  ... 
  827) Error:
  test_with_proc(YieldingAroundFiltersTest):
  NoMethodError: undefined method `to_query' for {}:ActiveSupport::HashWithIndifferentAccess
  /Users/matthew/code/rude-rails/actionpack/lib/action_controller/test_case.rb:146:in `assign_parameters'
  /Users/matthew/code/rude-rails/actionpack/lib/action_controller/test_case.rb:343:in `process'
  ...

there are several hundred just like it.

basically ActionController::TestCase needs this core_ext

here's my commit;
http://github.com/matthewrudy/rude-rails/commit/bbf66637439d266b7c3...
http://github.com/matthewrudy/rude-rails/tree/action-controller-tes...

and attached as a patch

notably, this is a tiny patch...
but I can't get the tests to pass without it
(and they still don't pass yet... don't even mention the rack-mount version issue)

Reported by MatthewRudy · April 14th, 2010 @ 07:30 AM

State: resolved
Milestone: 3.0.2
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to resolved
    • Assigned user set to Santiago Pastorino
    • Milestone cleared.

    ohh really sorry matthewrudy but it wasn't on purpose. I've been working on Yehuda's ActionController big changes since a few days ago.
    We have lot of troubles now on AC so try another patch assign it to me and i'm going to ensure you the preference ;).

    April 15th, 2010 @ 05:34 AM

  2. Jeremy Kemper