This project is archived and is in readonly mode.

#4393 ✓resolved

[PATCH] ActionController::TestCase requires Hash#to_query

Reported by MatthewRudy | April 14th, 2010 @ 07:30 AM | in 3.0.2

I'm trying to commit a patch to ActionPack
but all of the tests are failing

gradually I'm peeling away the reasons.

here's one

  ruPro:~/rails/actionpack$ rake
  827) Error:
  NoMethodError: undefined method `to_query' for {}:ActiveSupport::HashWithIndifferentAccess
  /Users/matthew/code/rude-rails/actionpack/lib/action_controller/test_case.rb:146:in `assign_parameters'
  /Users/matthew/code/rude-rails/actionpack/lib/action_controller/test_case.rb:343:in `process'

there are several hundred just like it.

basically ActionController::TestCase needs this core_ext

here's my commit;

and attached as a patch

notably, this is a tiny patch...
but I can't get the tests to pass without it
(and they still don't pass yet... don't even mention the rack-mount version issue)

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino April 15th, 2010 @ 05:34 AM

    • State changed from “new” to “resolved”
    • Assigned user set to “Santiago Pastorino”
    • Milestone cleared.

    ohh really sorry matthewrudy but it wasn't on purpose. I've been working on Yehuda's ActionController big changes since a few days ago.
    We have lot of troubles now on AC so try another patch assign it to me and i'm going to ensure you the preference ;).

  • Jeremy Kemper

    Jeremy Kemper October 15th, 2010 @ 11:01 PM

    • Milestone set to 3.0.2

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket