This project is archived and is in readonly mode.
fields with errors do not get wrapped in fieldWithErrors
-
Mike (at coverallcrew)After some hackery I found that adding label_tag to the array in the module: ActionView::Helpers::ActiveModelInstanceTag (/lib/actionview/helpers/active_model_helper) allowed the label errors to be highlighted.
Still cannot get select lists to be highlighted.
-
Mike (at coverallcrew)
Attached a patch that allows the label to be highlighted if there is a validation error.
-
Mike (at coverallcrew)
- Tag changed from activemodel, label to activemodel, haml, label
I'm may be barking up the wrong tree here...
This error only seems to happen when HAML is in the picture. The reason I thought ActiveRecord was unaffected is because I was using erb.
Any Rails 3 + Haml gurus out there - finding someone who can fix this is going to be harder than finding the actual bug!
-
Mike (at coverallcrew)
For what it's worth here is the patch with the Haml "fix". I have a monkey patch in my code that does this. It seems that Haml is what needs fixin' Rails 3 works just fine for this.
-
label_tag_error.patch
1.03 KB
-
-
FoobearYes, this is an issue of HAML 2.2.23 -- 2.2.22 works as expected.
(Rails 2.3.5 here) -
Rizwan Reza- State changed from new to invalid
Mike, send a pull request after fixing the bug to nex3: http://github.com/nex3/haml
I'm closing this since this is not a Rails 3 issue. Reply if otherwise.