Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActiveSupport::Notifications.unsubscribe("by name") does not remove subscription

#4433

ActiveSupport::Notifications::Fanout#unsubscribe assumes it is given a subscription object, but ActionController::TestCase#teardown_subscriptions passes it a String, so the subscription is never removed.

Patch: http://github.com/dchelimsky/rails/commit/3bd7148e63117517c1d7f21f0...

Reported by David Chelimsky · April 18th, 2010 @ 06:24 AM

State: resolved
Milestone: none
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: none

Activity

  1. David Chelimsky
    David Chelimsky
    • Tag set to patch, test

    April 18th, 2010 @ 06:26 AM

  2. David Chelimsky
    David Chelimsky
    • Assigned user set to Yehuda Katz (wycats)

    April 18th, 2010 @ 06:26 AM

  3. David Chelimsky
    David Chelimsky

    Related, teardown_subscriptions does not tear down both of the subscriptions that are set up in setup_subscriptions. Patch: http://github.com/dchelimsky/rails/commit/46798ec96e5b646ff69667c10...

    April 18th, 2010 @ 07:22 AM

  4. David Chelimsky
    David Chelimsky

    The previous patch was incomplete. This one improves the tests and code:

    http://github.com/dchelimsky/rails/commit/f0d1b1db89942a1e0b10df617...

    April 25th, 2010 @ 03:15 AM

  5. Repository
    Repository
    • State changed from new to resolved

    April 25th, 2010 @ 06:07 AM

  6. David Chelimsky
    David Chelimsky

    Thanks for getting this in.

    April 25th, 2010 @ 12:49 PM