This project is archived and is in readonly mode.
ActiveRecord middleware should be inserted before ActionDispatch::Cascade ?
-
Lawrence Pit
Actually, just found out that all my middlewares are sitting before ActiveRecord::ConnectionAdapters::ConnectionManagement. Perhaps the position of ActionDispatch::Cascade should be unchanged, and instead ActiveRecord::ConnectionAdapters::ConnectionManagement (and ActiveRecord::QueryCache ?) should go in front of ActionDispatch::Cascade ?
-
Jeremy Kemper
- Milestone cleared.
- State changed from new to open
- Assigned user set to José Valim
-
José Valim
Hey Lawrence, let's fix it but we need a test case first.
What happens if clear_active_connections! is not called? What failure do you get? -
Repository
- State changed from open to resolved
(from [3dfcb56e4585c8530be6dcc5129ae0c4d16c0dea]) ActiveRecord middlewares should be inserted before AD::Cascade [#4493 ActiveRecord middleware should be inserted before ActionDispatch::Cascade ? state:resolved]. http://github.com/rails/rails/commit/3dfcb56e4585c8530be6dcc5129ae0...