This project is archived and is in readonly mode.

assert_template :symbol always passes, even when it should fail

#4501

  get :new
  assert_template 'new'  # passes correctly
  assert_template :new   # passes correctly, but totally by accident
  assert_template :other # passes erroneously

This commit fixes the problem:

http://github.com/dchelimsky/rails/commit/a3aa4fc8d16eb2091365b4206...

This commit restructures the tests a bit:

http://github.com/dchelimsky/rails/commit/ce839d2bfb3f0d1463c0fa339...

I kept them separate in case you prefer to leave the test structure as/is, in which case just grab the first commit.

Reported by David Chelimsky · April 29th, 2010 @ 07:19 PM

Activity

David Chelimsky
- Assigned user set to Yehuda Katz (wycats)
April 29th, 2010 @ 07:19 PM
José Valim
- Milestone cleared.
- State changed from new to open
- Assigned user changed from Yehuda Katz (wycats) to José Valim
May 2nd, 2010 @ 11:01 PM
Repository
- State changed from open to resolved
(from [b3dcbedc67f49ef64f33570f3e24ac00a47c0181]) move assert_template tests to their own test case [#4501 assert_template :symbol always passes, even when it should fail state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/b3dcbedc67f49ef64f33570f3e24ac...

May 3rd, 2010 @ 12:47 PM
Jeremy Kemper
- Milestone set to 3.0.2
- Importance changed from to Low
[bulk edit]

October 15th, 2010 @ 11:01 PM